Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2232641pxb; Mon, 19 Apr 2021 00:04:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVU+IcEQVbsYbQOQkiWfPwRZ4DAGDIbqspmdp+qqbXc3tiOxtlwr/st4gazuHUffYs3Mc8 X-Received: by 2002:a05:6402:1103:: with SMTP id u3mr23484603edv.205.1618815894581; Mon, 19 Apr 2021 00:04:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618815894; cv=none; d=google.com; s=arc-20160816; b=tTxlIoPVMh78uFGC7lLF1DEe/FJs/DWHHVP1b2oByDepK7rAF2SE4euP9OMeorDrak H3tuQuFJX5Mg7B5FKhCAuCBirrR7vAeiQonZ/ELaIRAut/S3XLKqHdhK5WGv5iml/Su7 nwYRq2tZsYqldH+zPT/ge4JceqfDrDvjX8Uev2vrgnlOBOQJr9ye2RtFTO5IJArm4euy v+FQDS+Jhcn6osvTnstKF+oAueQpdkAyiA4kB5HcWCh6/smDKzQJ4xRQOmRJ0jf73GCe ZSXk4WDLg9+bFiIoxP/xyhXdIj1dE8GRzDe70q5/4c0CqAOoE5MfwgBtafMoU/fjCQ0k KOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RCCJG4HojmN/Dn1wT4Um30b53vmw38xaYfuMBCrfLAo=; b=0rf2x/XSoi4OPkmw9ZXngKWSLhR00erVWY582G/4zuLNXkLRWfGqB8i7iiXkuKRDhm LaykvXnfM0gbRlLSVQYCh+JRljB9f/T5/IFZiLAJKnHSP9ZVWZ2ta8YebY4okOnH1y19 zCB3NEMinJP6K75Je+ScceHaFvvJFn5h+53VybLBeJKXTqoSvPB6G0HbMs4c1QOnNOBW 5NVzVek+PoJVPdfcDio3Xn75wkSj/W44aq6Yq7eIM+oltNzkojqTJ8xYjVGiduNNPxeG 15X8LTSfltBc6pCc/yRk4vHNEu6kxWkVNmwny/VyQ+UHacFpkkE0R4UKo5J0LFHpFXpF hC9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EKeoPgTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si7312385ejn.673.2021.04.19.00.04.31; Mon, 19 Apr 2021 00:04:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EKeoPgTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237333AbhDSHBn (ORCPT + 99 others); Mon, 19 Apr 2021 03:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhDSHBm (ORCPT ); Mon, 19 Apr 2021 03:01:42 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 117E3C06174A for ; Mon, 19 Apr 2021 00:01:12 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id e9so186932plj.2 for ; Mon, 19 Apr 2021 00:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RCCJG4HojmN/Dn1wT4Um30b53vmw38xaYfuMBCrfLAo=; b=EKeoPgTHMyy0fx0lp+APzZr26AnOM7vLtzlkdsp4X3i3Ku0gw8ERTZpZbnMjue9s50 wJXVb/v/7Cm9n1IlIUad3e41FHmAx27Ir1ZrwYvkXOA4aSUErRQRbmr8IQDso81OS29H sqs0KEH7m6ZYpTluW9idrtCl0GNlXrqFh6s+lDcoFlY3ohfamlkhnUfTe8fQhsVBD4pb 1whaHRBNDH9GYq5V60TNBJOG32gynjY+FXqAboUahDjetFhF2Seao/wNtEYL1cCQdmUP viNS5/mq7GRwuDQyq15ixfS2/i55V5W1KHdPnaUHw0aSLMK+NvoUFPqYC8nbbgFvrWWK NoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RCCJG4HojmN/Dn1wT4Um30b53vmw38xaYfuMBCrfLAo=; b=e3YYngqo+9SPZmK/48KjoOrqiZelD5a4mVhmjlIqP9EsPMaXN/d781s5g4qKc7PlI9 5JoQH+TaAvXTxga70T4e8gavKT2D3DZeGRf3OTAimDYoF2hSfeds57kL3beFJPzRGVi2 cxaGGpa6ZDf5P2V0PYFmf/y+1XV90zG2p5uGqwMYHnkpstnpUnG+SPZohn+3jd9VJMjq CMG4c+0dnRcadxirTF9YrYQcHkzbWrHZry5U7SG1bSJtueE29DmNG3/pz219148EsGS7 hFsFjTtZ5Smpkk7J/JzHljP79IugCp8+2zQ+KmoWmb9cWGqcWRFidSLZ6R3l+4AOK8ar tOxw== X-Gm-Message-State: AOAM5308BnZGhbnqGZ9LxI5Ihfny0UP5hVFhNT+SiixJ4IrQnii1oRga OXDqmjQ8nIlK3jsl6PlYjfurzPk6Q3J7vw== X-Received: by 2002:a17:90b:4a86:: with SMTP id lp6mr14301846pjb.160.1618815671557; Mon, 19 Apr 2021 00:01:11 -0700 (PDT) Received: from localhost (121-45-173-48.tpgi.com.au. [121.45.173.48]) by smtp.gmail.com with ESMTPSA id b17sm11100117pft.170.2021.04.19.00.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 00:01:09 -0700 (PDT) Date: Mon, 19 Apr 2021 17:01:06 +1000 From: Balbir Singh To: brookxu Cc: adobriyan@gmail.com, akpm@linux-foundation.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/2] delayacct: refactor the code to simplify the implementation Message-ID: <20210419070106.GC8178@balbir-desktop> References: <1b0063b922ba18e36a55286a6c23fd74d71b21b0.1618275619.git.brookxu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b0063b922ba18e36a55286a6c23fd74d71b21b0.1618275619.git.brookxu@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 09:37:26AM +0800, brookxu wrote: > From: Chunguang Xu > > The existing data structure is not very convenient for > expansion, and part of the code can be saved. Here, try > to optimize, which can make the code more concise and > easy to expand. > > Signed-off-by: Chunguang Xu The approach seems to make sense, but the test robot has found a few issues, can you correct those as applicable please? Balbir Singh.