Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2301034pxb; Mon, 19 Apr 2021 02:18:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy68xajD+5uVXbQeouaF+VRfsOMk7PcmbEzdqoiHbLLzWSVyKQ0advnp/gBQtnrn+ZImEqr X-Received: by 2002:a17:907:9894:: with SMTP id ja20mr20456628ejc.428.1618823929052; Mon, 19 Apr 2021 02:18:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618823929; cv=none; d=google.com; s=arc-20160816; b=mfY4zTiNlfCkx1gpFNYR8Ym+Es9B1SRN8Jjpm/TNO7OTNzOKLI09s5cWrwgBGQFSMk +9r9IYX31XA13Uz83VIXgoh/bY7f7uLeW8vWm+MPCGJL9VsKE17zk/Men2cG7pYxHlry 7o/4Os6NBiOvB8PksoeY0GanUm1x/c+Z6nx2aVz4ZZ2K0r/G+9YW7UCGcO5avRJbVm0N 8c6r71cHHFoHgDK8Z9m3zgxqUe5/uEyfch8fMQlbuuqoqeceU0HTq59UzbLsX5gGYYwK 5qIKv53jw4J9JKu19RNgSuxg/yeRJNs7q34K+81DTHLWRxjOfLgajDs3l1c4+SscfwiZ cCkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=BRE7kUfgnyAkLcXnn28/l9BglZanciveXxOogGBkKYA=; b=c93tBmi08hJ/isZnThRykiVlImIsMgmhZeNkBsPfrA2+nUtz9MZsvb1vrq3WLyMLsN zehiUxjzKmYo66JhpREU9/6dAPV5fLW2/uDs+9H+24cByoEYEU/MrXr44+sz5O1OjycM E+k0Ai1+Q2DVaVuZZEacHYZpg5dLK++f0PgMJas5Tu1rPEsKNFp2KAL8q9Aa7pH8dxoR OHyx9agk35Ivpm3UXi5rXo0NM3wzFu3H4KVTgt90lKeGXen9KG3CrH3LOqElyfyssNGg Eh0EhlerFa5mCPsahPi9YQjNdZQ630GJmxpHylOHStUB6V/Vm0SAgnt8iRLmVUCZSK+1 lgiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 16si13558405edv.248.2021.04.19.02.18.25; Mon, 19 Apr 2021 02:18:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238001AbhDSID2 (ORCPT + 99 others); Mon, 19 Apr 2021 04:03:28 -0400 Received: from mail-vs1-f41.google.com ([209.85.217.41]:44909 "EHLO mail-vs1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbhDSID0 (ORCPT ); Mon, 19 Apr 2021 04:03:26 -0400 Received: by mail-vs1-f41.google.com with SMTP id t23so788928vso.11; Mon, 19 Apr 2021 01:02:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BRE7kUfgnyAkLcXnn28/l9BglZanciveXxOogGBkKYA=; b=gbQqLesm1el/IA5e0SjWJjQW+nJzz0LSVH2i1Jo4EoU3EKjvEAUJbqrWkBaorJMNbj uM9nYaLzds+a9QjapGruGt8+j0yaBfPN9q3h1lxbYaOSnnFDNOAS7yICZwurBCiorxhr STeqJV9o8CsRudc+klsEcb3Z2nOod5QONLbsvv+v7vncAqOyJ5iCNjddNItsZRQgzPm5 zTN9Q1/lTyvgG1qWnOVdzhDFXQ4NFhgH4UV3mLXhMbeLiU4ytCY2N/8Oqr8MOOB9T9uh X1SORJVoS7vEN9Lmg1qijjRWq0YCWUIFK/7ILH/21bz60Ejd900J3Q9rRVJ4iBbxVEAa qUYA== X-Gm-Message-State: AOAM533dOpzSwITZRKFoFdsVsXMwJW0khWpz8ug43vRiacslFo6Ychf+ 9JTt4An9JPbtjwTIzJfOxPNvqO7xCNr99AaD4Lk= X-Received: by 2002:a67:f503:: with SMTP id u3mr12324042vsn.3.1618819375153; Mon, 19 Apr 2021 01:02:55 -0700 (PDT) MIME-Version: 1.0 References: <20210417132329.6886-1-aford173@gmail.com> In-Reply-To: <20210417132329.6886-1-aford173@gmail.com> From: Geert Uytterhoeven Date: Mon, 19 Apr 2021 10:02:44 +0200 Message-ID: Subject: Re: [PATCH] net: ethernet: ravb: Fix release of refclk To: Adam Ford Cc: netdev , Adam Ford-BE , Sergei Shtylyov , "David S. Miller" , Jakub Kicinski , Andrew Lunn , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 17, 2021 at 3:23 PM Adam Ford wrote: > The call to clk_disable_unprepare() can happen before priv is > initialized. This means moving clk_disable_unprepare out of > out_release into a new label. > > Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk") > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds