Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2312896pxb; Mon, 19 Apr 2021 02:41:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3reQmeXXo682Q32b7aBpBhLW4EK4U9JpyhnYTUEGhdAIG2DpvzeTNrg4WwQcle9mstU8D X-Received: by 2002:a63:9dc5:: with SMTP id i188mr11087010pgd.191.1618825266014; Mon, 19 Apr 2021 02:41:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618825266; cv=none; d=google.com; s=arc-20160816; b=Uy3H+J1KDc6BK7GnOMYHlm8gG4qAwJpm/BN3r+dxqm4NHagpuT93g1yXrZr1hM013F ZkYIdkJ4tBJ64LRbr3PMCTJMfQosNScPQGspi3jNYDPvwwHv/1T+0eDTGJe9r+dhaDoA WC7Jhdet0aSYyCJNcg8FnFvzsOONe2vmKmry538aqG1+XPIqCVm9Fr+oHEUuOKqXbL2Q kqE3HkqOP6mQ/qoCeEKysCQF/ZulkrAJzfMn5SHy3JGv1dC9MQ462Ijlgrexb5HUk0Z1 eeogyhrfnPvPCtWUN3Bijq7Ly12VnPGGz8iwOFcoraGZqolKEPV+P/RQwTll3i12Twmb 2b3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=xSJyOBHu78Kak9+awi1Z3ydokklJB3m48+P9VEYpazA=; b=igvRQ8/tKARBEe9vpSSHPyTN3CS1rSusqZguT1Bokam4xNNA0XRWlD0b7R4E7F/879 ra/mAgw0BrwIqriD1ExnU9VBdkLWmXEmko6yZR/7BiBZKCW4ov68bMT6a2ss6+AYUOV3 LPEgBVlGm9xyuUxmhOLpMKEQ0CBsGGi/HK1YmrZXo150uDdfbV0NG6HWjoFWDcARu5+7 YDnJVkQYRL76c450zb4gLh+/avn8AhFtRR6T+GtAAqsxnKxaWEastAbULVssv2UzZKIu K4sQCl9f3ry+J0OGCgShVxJcdNY5NDEyPxqQg1IhHYHUFFRx1rrPP79AjNTeg7UXoVEA 7+iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QHd+LiEV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kk2si15234923pjb.83.2021.04.19.02.40.54; Mon, 19 Apr 2021 02:41:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QHd+LiEV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234906AbhDSJb2 (ORCPT + 99 others); Mon, 19 Apr 2021 05:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233520AbhDSJb1 (ORCPT ); Mon, 19 Apr 2021 05:31:27 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3A75C06174A for ; Mon, 19 Apr 2021 02:30:57 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id w8so19321819pfn.9 for ; Mon, 19 Apr 2021 02:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xSJyOBHu78Kak9+awi1Z3ydokklJB3m48+P9VEYpazA=; b=QHd+LiEVf4dJ8dlCyZiExD9pR7dIW1n8qvgMrjrd8LNY4rOVnAZ0hN2L37ggxaLtym XVp+9qkWCOSoh4nlAccmVdoMHuIlcwzH8Mb8z05LW/o050Iekx3+mwMJ55xdZ0GZ6WIu 6FDnEp79wRPEiD9KNaccfgx1FSApcjO4m7H4S9ZhQqHhIyNColZ9a3xKHd5L/iiIUmJG 5fHDVpMceVTUBuYl76FrdOnYCbaA96An/WOi5t5K/2Tiu/A/FofZwjMw99zyQbbi3deD 2W9Q2lsdAK/DfqRGIPb9yyeGeJrDHc1ECFojW75TsL3YYgjfyUlYrEXwcVxvDYFD5r73 apzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xSJyOBHu78Kak9+awi1Z3ydokklJB3m48+P9VEYpazA=; b=UgN4d/GyLHUeD1BiW7zEKW/hlha5qTHt56PBzP6PE1GvEsQ/9eSt8Qs3EbjIL8wgAr 4F4lM+YZwx986xyzO86nPiA/dKeDr0CqM626kptzADjoSMHGcixvvQDiNBf8g5uxvqnA oOmr9LgGeaq+c9H98tmkC3KfrcrhcEXJjuGhkIYgGOrDgaJqgeh3trD24ntBPz/3iHyS JXYhVJhv+kZdZdYhFpCWdktww8xWj5vknnnYL2NHLGWjP3fO6Ln2l1e3aA/CN2JDhrcF g6g7OK58md7zU6erXLh/Ft/KMGDzeU5aA0R2BgrPyjCjpWJCGTqEe/L8P6scNz1GaBF3 NIxw== X-Gm-Message-State: AOAM532WHClLIHLrswWZNd9wzRT8+KaR5JDmUQc15jviVjMqLlA/kcUb Vx3/Ih1LvuoymQ5OfBCoy5HOw8btgHk= X-Received: by 2002:a63:5214:: with SMTP id g20mr11089898pgb.158.1618824657041; Mon, 19 Apr 2021 02:30:57 -0700 (PDT) Received: from [127.0.0.1] ([203.205.141.39]) by smtp.gmail.com with ESMTPSA id 11sm15560833pjm.0.2021.04.19.02.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 02:30:56 -0700 (PDT) Subject: Re: [RESEND PATCH 1/2] delayacct: refactor the code to simplify the implementation To: Balbir Singh Cc: adobriyan@gmail.com, akpm@linux-foundation.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org References: <1b0063b922ba18e36a55286a6c23fd74d71b21b0.1618275619.git.brookxu@tencent.com> <20210419070106.GC8178@balbir-desktop> From: brookxu Message-ID: Date: Mon, 19 Apr 2021 17:30:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210419070106.GC8178@balbir-desktop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balbir Singh wrote on 2021/4/19 15:01: > On Tue, Apr 13, 2021 at 09:37:26AM +0800, brookxu wrote: >> From: Chunguang Xu >> >> The existing data structure is not very convenient for >> expansion, and part of the code can be saved. Here, try >> to optimize, which can make the code more concise and >> easy to expand. >> >> Signed-off-by: Chunguang Xu > > The approach seems to make sense, but the test robot has found > a few issues, can you correct those as applicable please? OK, i will fix it later, thanks for your reply. > Balbir Singh. >