Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2377568pxb; Mon, 19 Apr 2021 04:27:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfewO1BVp/W+/1jjmYb3X1JVx30j1/LDFEuMwxMiPfSUp9D7Md77mIIaeb6jau3hoMN6FM X-Received: by 2002:a17:906:6a49:: with SMTP id n9mr21523367ejs.397.1618831667195; Mon, 19 Apr 2021 04:27:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618831667; cv=none; d=google.com; s=arc-20160816; b=H3cXVdkEOJNVc6X/Rvc7RoDEFjnX4tovp+fnzyToXxVlbAcPvtEg+h0MHAwa6Hka37 v+ysaeYdlSu9Dxy6/lEl0UytX5KlMziaUMwJfOtGNTLqUJp158Jt77qYY2a+l30JbvOE sLpx3bN03vuM7RigK2MctCDtkCDvfig2Gb6NJThPhALfOQsvhQY++zNGkzG5H63enO5i xaorkx28+HYfRE7NnzlZ8dR+PKFXudUU+Ct5ase6oRqFunSQdQ3cS2aZTt0lFLhbfFG4 MDEZ5xNAW4tq8gvqcT18a/7OccKah6mBalzdYTlqIghWD6ge7Tn0Ohis9bIhiRUda8dO GKXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x3qpL5c2x6AC1G6cAf8hh0pGiHggQ7osZn3E/d5QYMI=; b=HCMx+n/OiK0nAF5lxlC71uVW5DNDmsL9UlTWKX6uihycOnfcb+iVXPJVHTXDDWjjnF vGrVJsZVquICxWWlUc1fBWgVgtPhSS4ptFvTpnVpVdCQHhjQg9tUsq/6iOyYCpLbtZpT ii9HncAl3/BGn43L4qQiiOpc85JcDvbxJ9jPFe7bq+uDFtl2tZbWvVmVDwhxUVVyAZlL Yt8V83tqxcjxWoDCaY0TKa4hQyINhSZooQ6CcDX4JIloJm9y7ggI+BinZvjhnCUfZf4A RgDecfA8dJ63sJdPsqOr0nX78dEAECIBtpI+dyiNLDuJM/U4h1TRoXE6Hg8E9YZoBKZ6 dZEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r3IHz8YW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp21si11838810ejc.61.2021.04.19.04.27.21; Mon, 19 Apr 2021 04:27:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r3IHz8YW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237871AbhDSKfw (ORCPT + 99 others); Mon, 19 Apr 2021 06:35:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:51668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhDSKfu (ORCPT ); Mon, 19 Apr 2021 06:35:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C042A61166; Mon, 19 Apr 2021 10:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618828455; bh=x3qpL5c2x6AC1G6cAf8hh0pGiHggQ7osZn3E/d5QYMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r3IHz8YWsF0Ua0bwxfM55rI+FrWNkfcwAUYD0+NzXflBNGUBzhYDGCUmTNikiLug6 NJbVOjHVyw0nWL7UHsqt5WIdIeEFf4fVdIKGhgmSxWBU9tIHc67qDX2XB6/tMiCqGu hIFugWPAi+XQs5K9WGQotlpnAxC+w7SdyvmA/yOyqUKAO3cAkJkTxWEzTud1UNlMuW RAA0LJxYgy3PvGw196b5l2q3grFPwms86+oJy8/+8+oYOJOYqVjSOfbFCQmLH8Mluu ucgAeYdtkM5xxER3TRxc3XMnuuV3QYC1fZsixV9sfvObQUOkaknT0h+dligs0JHB2i yBxdgDMrM5yLQ== Date: Mon, 19 Apr 2021 12:34:09 +0200 From: Jessica Yu To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , linux-doc@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces Message-ID: References: <20210410015300.3764485-1-swboyd@chromium.org> <20210410015300.3764485-6-swboyd@chromium.org> <161871075477.46595.10848605889976259732@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <161871075477.46595.10848605889976259732@swboyd.mtv.corp.google.com> X-OS: Linux gunter 5.11.6-1-default x86_64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Stephen Boyd [17/04/21 18:52 -0700]: [snip] >Sounds good. It means that some more ifdefs are probably required vs. >making the array size be 0 when the config is disabled but that isn't a >big problem for me. I'm reworking the code now and will test and then >send v5 shortly. Thanks! Great, thanks a lot Stephen! Jessica