Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-11-lee.jones@linaro.org>
In-Reply-To: <20210416143725.2769053-11-lee.jones@linaro.org>
From:   Karol Herbst <kherbst@redhat.com>
Date:   Mon, 19 Apr 2021 13:46:02 +0200
Message-ID: <CACO55tu=3H=vEcE6zDA951CqQf1wmKJrVMvBy=EEpp+R5MZG0w@mail.gmail.com>
Subject: Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused
 variable 'ret' from function returning void
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        nouveau <nouveau@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Ben Skeggs <bskeggs@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 16, 2021 at 4:38 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/nouveau/dispnv50/disp.c: In function =E2=80=98nv50_mstm_=
cleanup=E2=80=99:
>  drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable =E2=80=
=98ret=E2=80=99 set but not used [-Wunused-but-set-variable]
>

same comment here: we should really check if it's better to handle the
error and report it back that something failed or so..

> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/no=
uveau/dispnv50/disp.c
> index 4801aafd9552b..351f954989530 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -1386,12 +1386,11 @@ nv50_mstm_cleanup(struct nv50_mstm *mstm)
>  {
>         struct nouveau_drm *drm =3D nouveau_drm(mstm->outp->base.base.dev=
);
>         struct drm_encoder *encoder;
> -       int ret;
>
>         NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name);
> -       ret =3D drm_dp_check_act_status(&mstm->mgr);
> +       drm_dp_check_act_status(&mstm->mgr);
>
> -       ret =3D drm_dp_update_payload_part2(&mstm->mgr);
> +       drm_dp_update_payload_part2(&mstm->mgr);
>
>         drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
>                 if (encoder->encoder_type =3D=3D DRM_MODE_ENCODER_DPMST) =
{
> --
> 2.27.0
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau