Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alexander Egorenkov <egorenar@posteo.net>
To:     Christoph Hellwig <hch@infradead.org>,
        Alexander Egorenkov <egorenar-dev@posteo.net>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] lib: scatterlist: Fix SGL length in sg_split() if
 !CONFIG_NEED_SG_DMA_LENGTH
In-Reply-To: <20210419092325.GA3215674@infradead.org>
References: <20210418081441.5040-1-egorenar-dev@posteo.net>
 <20210419092325.GA3215674@infradead.org>
Date:   Mon, 19 Apr 2021 14:35:50 +0000
Message-ID: <87y2de4a0p.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Christoph Hellwig <hch@infradead.org> writes:

> On Sun, Apr 18, 2021 at 08:14:41AM +0000, Alexander Egorenkov wrote:
>> If CONFIG_NEED_SG_DMA_LENGTH is NOT enabled then sg_dma_len() is an alias
>> for the length field in a SGL. In that case sg_split() wrongly resets
>> the length of split SGLs to zero after it was set correctly before.
>
> Why is this routine messing with sg_dma_address and
> sg_dma_lensg_dma_lensg_dma_len at all?  This whole sg_spli() routine
> seems rather dangerous because ownership and state of the DMA mapping is
> entirely unclear.

If i understood it correctly, then sg_split_phys() creates a new SGL
from the given one, so it makes sense to initialize DMA fields of the
new SGL. sg_split() allows one to split the given SGL into multiple ones
and the original one doesn't have to be dma-mapped which is indicated by the
parameter in_mapped_nents > 0.

Regards
Alex