Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2598295pxb; Mon, 19 Apr 2021 09:14:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX4cAGloukI3J78vFaV+yAK5x1Q+7V0V103g/B5bOgfapfjZPi4ffgDRkc4kI9V/XzcqL7 X-Received: by 2002:a17:906:7104:: with SMTP id x4mr22868468ejj.101.1618848849670; Mon, 19 Apr 2021 09:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618848849; cv=none; d=google.com; s=arc-20160816; b=FlfDyKFbvJQEEyHExZhtiBOOjZL8pjSPBNYjCJppyB54iPkbKIDlCfPUArEc/kglsc umQDpP0iGH7cxKVhjdQavlFZxVtyjdTbBy+fZfFoQuueQs7jEOOw8oiCeQ1RKmT4G/mh bD3hUJ2LpGrwsvlf5gHIs+fg+VfmdzydSOmvvoh1TZaXr4bGtx15EWyVfe8TwTFeLVzV JCdd/FGrDCP71WT7xWYW+lAeXm3KoZhT6pMCMfVoyS+FKoT8P2rnZoTn9GsPUnIj+JCo teGWmQcfcXKA9R91Xoj3ZrInZi90dkOheoX0vYXL9vvfff6catvCh+/m4luHBHW0srig HRYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=6C2ypx1ltTtAbaNb1djC1piRseYP7dsd7kJM0vd662s=; b=LlQYPgsdUtkcV2Woqhr8uLsW3tlU0z2SUt3BHl2tUlISRz2TSM883TWB8XBzlKemhj y99b+FlmMmkIzGAMM6YnG11wn6owpjNm62xMt+BgsteIy2NtKG3BLR8ms8E9l7nDG88f vhOi6MQkSKE8ZTmjC9VKhfSxoWxT+zRZN91066BAt+3j41P8fPRilsCuf45LqK3dga+h qOGBt5aIP3QPhntMpHAPDDjSRcnm6eg/eSMGjJSmo2DRJeNDw5/Ra6N7N9xq3forq8t/ XVU/ZxDBYyh/2fpm8N1/p8p9mFMGAnt7swCG9UfObhpRj+26haEEES6L6++bqxnDawhv L5fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qoi9lv3o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si12574626eds.434.2021.04.19.09.13.46; Mon, 19 Apr 2021 09:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qoi9lv3o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241377AbhDSPeZ (ORCPT + 99 others); Mon, 19 Apr 2021 11:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239906AbhDSPeZ (ORCPT ); Mon, 19 Apr 2021 11:34:25 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D688C06174A for ; Mon, 19 Apr 2021 08:33:54 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id y1so2262480plg.11 for ; Mon, 19 Apr 2021 08:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=6C2ypx1ltTtAbaNb1djC1piRseYP7dsd7kJM0vd662s=; b=Qoi9lv3o1Ko56QjAVFcNOHsmAPb7DFUAABLCuRfkITyjvV0bqYJxkIUnH3ar3AXZCv 7nLFlRSy45HRQ27c42CnVU0IivkzivxpGBMZgrF/yeujfCrPrG3vPTYkqbGpQKA9uEpC Mj171RG6/IL+F7+us2tZWtNfATiDzlHrDtU5VuHafDgOrKbW17zDvQSwrdUsCcwGvHEP argcqPGM2cSQq99+ROrED2aW7aoD4/fZjy53eQjtzmPWU+MMl+cWTWCPsbJsWi+q3HKH ksqHkqNeCPB4Trzq1EU0Bufg7QlLHnpkUrQcMHZgGVIFecu3uyv75P9q5Q1NB3rRK55k mOwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=6C2ypx1ltTtAbaNb1djC1piRseYP7dsd7kJM0vd662s=; b=BHUxBD7f8oibdJPVinDXZC2jI0+sKwHyMgVTy7qRSzKtmZ6kZ5RwcIQhhkSGcVWLid DJIK5z+451/8qVgMSTlujDW7QQW/HDB3RFPVDvM9IT3MZpRpII/6SPKTfmh7glW166NK xKijAP8bIVmU0q6cred9hC0FUMmmWRAAAHJPmwJLSTktLllpy5s2GFhTbz5g/kPBdsIh H6vl6ZZY5peb6W96oKJiOtI4w1Qvuwko6i4qdLBkNGoV5oP9Vaz1e4iDFptPIdHjDvDs IjvQGKUxmSkm2tWGBLM9pQ4IoTTQTT55GL2YX2Bgex2FEtQzx1rrC6v9UQAd4wn3sEbz Oa9w== X-Gm-Message-State: AOAM532HsxDrk4cGif4k7dX2UFQ16CyCBsPtw4hA6F2pHKva+FvXu6uX ZsLWLH9qcEw6npvhPUXHqLE= X-Received: by 2002:a17:90a:7897:: with SMTP id x23mr8624574pjk.133.1618846433453; Mon, 19 Apr 2021 08:33:53 -0700 (PDT) Received: from ashish-NUC8i5BEH ([182.77.14.23]) by smtp.gmail.com with ESMTPSA id d3sm15694597pjw.35.2021.04.19.08.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 08:33:52 -0700 (PDT) Date: Mon, 19 Apr 2021 21:03:48 +0530 From: Ashish Kalra To: =?iso-8859-1?B?Suly9G1l?= Pouiller , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: eashishkalra@gmail.com Subject: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning Message-ID: <20210419153348.GA22782@ashish-NUC8i5BEH> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared. Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared. Should it be static?" is brought to notice for this file. static keyword should be added to prevent this warning. let's add it to make it cleaner and silence the Sparse warning. Signed-off-by: Ashish Kalra --- drivers/staging/wfx/sta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 12e8a5b638f1..d855d87c2102 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -200,7 +200,7 @@ void wfx_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags, mutex_unlock(&wdev->conf_mutex); } -int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps) +static int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps) { struct ieee80211_channel *chan0 = NULL, *chan1 = NULL; struct ieee80211_conf *conf = &wvif->wdev->hw->conf; @@ -230,7 +230,7 @@ int wfx_get_ps_timeout(struct wfx_vif *wvif, bool *enable_ps) return -1; } -int wfx_update_pm(struct wfx_vif *wvif) +static int wfx_update_pm(struct wfx_vif *wvif) { int ps_timeout; bool ps; -- 2.25.1