Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 19 Apr 2021 09:57:15 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH] f2fs: fix to cover allocate_segment() with lock
Message-ID: <YH22a55sexxwmGCe@google.com>
References: <20210414012134.128066-1-yuchao0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210414012134.128066-1-yuchao0@huawei.com>
Precedence: bulk

On 04/14, Chao Yu wrote:
> As we did for other cases, in fix_curseg_write_pointer(), let's
> change as below:
> - use callback function s_ops->allocate_segment() instead of
> raw function allocate_segment_by_default();
> - cover allocate_segment() with curseg_lock and sentry_lock.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/segment.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b2ee6b7791b0..daf9531ec58f 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -4848,7 +4848,12 @@ static int fix_curseg_write_pointer(struct f2fs_sb_info *sbi, int type)
>  
>  	f2fs_notice(sbi, "Assign new section to curseg[%d]: "
>  		    "curseg[0x%x,0x%x]", type, cs->segno, cs->next_blkoff);
> -	allocate_segment_by_default(sbi, type, true);
> +
> +	down_read(&SM_I(sbi)->curseg_lock);
> +	down_write(&SIT_I(sbi)->sentry_lock);
> +	SIT_I(sbi)->s_ops->allocate_segment(sbi, type, true);
> +	up_write(&SIT_I(sbi)->sentry_lock);
> +	up_read(&SM_I(sbi)->curseg_lock);

Seems f2fs_allocate_new_section()?

>  
>  	/* check consistency of the zone curseg pointed to */
>  	if (check_zone_write_pointer(sbi, zbd, &zone))
> -- 
> 2.29.2