Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2760585pxb; Mon, 19 Apr 2021 13:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvyHX9K9vd8njamHE04jApKsfozy0rmpd+gvzMRjZ/GQw824neTsxyLk5uSvlEQNLbYQON X-Received: by 2002:a17:902:4d:b029:ec:94df:c9aa with SMTP id 71-20020a170902004db02900ec94dfc9aamr11925153pla.7.1618863254808; Mon, 19 Apr 2021 13:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618863254; cv=none; d=google.com; s=arc-20160816; b=LacrYIu+KERPfkTTxUK7mxEPMJBtm5KMDxWhVSP2qq0R71Z6Eb6MkWlnRQdIQ8qVxJ HZKuL5/RMJDe00Ba90iObMOQSU+RitPLtHl5qHCPwgkxfAW2VeH+FsDVMGDShIHgqhQD KrcNWFv+LrTXikMxG50YcPU8FwCKvq/tGPAb7pNP1efyEInAnQZb4u0KXhDVpeCHcD+K XT3+IcPdArWDg9sjNUuTgB8m8Hib6ipvlJx3zSVsA394mn/ao5WiMDCOi5JyecBXxgy1 JnPLlhmJEULK/uc+hfQL1P9xgTnrex9A0CCB2RJ2j2+jsNGRaAYcE/20X13EQFwcA9gB qiag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature; bh=LFLAtSvytla0zTYcsW46mWeyZlofOCWa3x8xY0lnO7M=; b=mPCv4Achg6aka4ZLQ9wFVW5Nq0pyohBIx7TFsjZPLonlaODOEMkEh1N7h7ENAA6Eoj UeRDmuhevFRHD8tteuWBWRrQJLSWnmdMKz6ziYwZ/frpyzKM0a2tKRc1e7DlVsBlYCUI ISsJBtd12fHIh1qDEnzacZiA9haQptDBG5U5wuTFgySE9ggtpP0qA+yimciHKMx3iDcZ PDZeqPQjaa0KDfzZx8xF0X7CHn/YGLa5VaHvK0gaALF+RzUOCcnkB9/fhQf7bjGzR8xg 79q35NBaq/yqFtPFF4R0AAuUJY1k/jmKJAnnibStQcsFoj+ywDTZyHS5estilLk3Sema mDHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=H8hCSiqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si20035114pfd.331.2021.04.19.13.14.02; Mon, 19 Apr 2021 13:14:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=H8hCSiqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239342AbhDSQ5k (ORCPT + 99 others); Mon, 19 Apr 2021 12:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhDSQ5f (ORCPT ); Mon, 19 Apr 2021 12:57:35 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 873C3C06174A for ; Mon, 19 Apr 2021 09:57:05 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id y1so2409496plg.11 for ; Mon, 19 Apr 2021 09:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LFLAtSvytla0zTYcsW46mWeyZlofOCWa3x8xY0lnO7M=; b=H8hCSiqQKIDKul/wf025S/2I8kyN/iAfc/+Te8+ygVBtigfjKvw+qcK3fdE/uG6iQb dbo/uRWNeF3x7j2Ybb0bk6EPtOkJrtvLoJeR3QT7hzwpWPgQw5mP0ZoEyIQB3r0shGzt wKqGYK5TtI0KlBz2LxjgiBdIb49oM5EMtcCBwnLWTW5iJCNyFZI2qomf2/2LUFJNrm5T YhevHK1tVhAF4F7A8tJ0bBoPfCl/taHnQhARBUQngM9VIm7yksjXNhLidnxpuIz4Gg2Z 7gbZi5sTtzhRsoSrRraHSqZDOpE0/fXl30rmtV/exhogkg6G5tkLuoGCR9s3g3bhLCyg BuBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LFLAtSvytla0zTYcsW46mWeyZlofOCWa3x8xY0lnO7M=; b=rUfoUk2yVaXq06drBx9v9QwbGTVp9w+FB8lMJlDwp5fwN370Rmc+fIVP60coIYm1Gj yiCyybfqpnDZqfEN+cC1vKjFPO8GKjQrlbAQ6Y9184lUxKQIaPewWBpcnpUIhOpTLKl4 V2adTo0kdm/yL6/ZSBzWF687ksM8grXXJE6cseJunkIoBIcUY2ONr1qeYb9ZR5+Zx2+G e45lQgz3Pfog4J8Z7QS/PG+Tku4DEYM1GwDg2YcmULGtXhd2tq9AZ02SXqPDU7z9Ek/d W6ycKrx0oOUbzEYvqM65BhFunywlGn5K3DuZwQZ29HrNJXuVsYLDZi5j7v1kAwUsZwVH i6QA== X-Gm-Message-State: AOAM531dH7XmeDz7bw4HM0I52FkzqCgeteyhEMU854GtDnzLNBBU0QH5 nIxe3EcyZGrN1P7sGywUnbc= X-Received: by 2002:a17:902:b483:b029:e9:eef4:4f16 with SMTP id y3-20020a170902b483b02900e9eef44f16mr24796074plr.38.1618851424942; Mon, 19 Apr 2021 09:57:04 -0700 (PDT) Received: from ashish-NUC8i5BEH ([182.77.14.23]) by smtp.gmail.com with ESMTPSA id 76sm7498096pfw.25.2021.04.19.09.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:57:04 -0700 (PDT) From: Ashish Kalra X-Google-Original-From: Ashish Kalra Date: Mon, 19 Apr 2021 22:26:59 +0530 To: =?iso-8859-1?B?Suly9G1l?= Pouiller Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Ashish Kalra Subject: Re: [PATCH] staging: wfx: silence symbol 'wfx_get_ps_timeout' was not declared warning Message-ID: <20210419165659.GA2363@ashish-NUC8i5BEH> References: <20210419153348.GA22782@ashish-NUC8i5BEH> <3163466.7bx4QQXRp1@pc-42> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3163466.7bx4QQXRp1@pc-42> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 05:55:34PM +0200, J?r?me Pouiller wrote: > On Monday 19 April 2021 17:33:48 CEST Ashish Kalra wrote: > > > > Upon running sparse, "warning: symbol 'wfx_get_ps_timeout' was not declared. > > Should it be static?" and "warning: symbol 'wfx_update_pm' was not declared. > > Should it be static?" is brought to notice for this file. static keyword > > should be added to prevent this warning. let's add it to make it cleaner and > > silence the Sparse warning. > > Hi Ashish, > > Thank you for your contribution. > > It seems that this issue is already fixed by commit ce59858bbc10 "staging: > wfx: make methods 'wfx_get_ps_timeout' and 'wfx_update_pm' static" (merged > in master in version 5.8). Can you check you are working on the last tree? > > > -- > J?r?me Pouiller > > Thanks Jerome It seems some sync issue with my source code.I will update to latest and correct