Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] smp: add a best_effort version of
 smp_call_function_many()
To:     Luigi Rizzo <lrizzo@google.com>, linux-kernel@vger.kernel.org,
        peterz@infradead.org, axboe@kernel.dk, paulmck@kernel.org
References: <20210419184455.2987243-1-lrizzo@google.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <d7371d20-e2d8-c5d1-b59b-850d86bf7a83@infradead.org>
Date:   Mon, 19 Apr 2021 11:52:33 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210419184455.2987243-1-lrizzo@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 4/19/21 11:44 AM, Luigi Rizzo wrote:

> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> ---
>  include/linux/smp.h | 10 ++++++
>  kernel/smp.c        | 75 +++++++++++++++++++++++++++++++++++++--------
>  2 files changed, 72 insertions(+), 13 deletions(-)
> 

> diff --git a/kernel/smp.c b/kernel/smp.c
> index aeb0adfa0606..75155875fadc 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c

> @@ -693,8 +715,32 @@ static void smp_call_function_many_cond(const struct cpumask *mask,
>  			csd_lock_wait(csd);
>  		}
>  	}
> +	return busy ? cfd->cpumask : NULL;
>  }
>  
> +/**
> + * Extended version of smp_call_function_many(). Same constraints.
> + * @mode == 0 same as wait = false, returns 0;
> + * @mode == 1 same as wait = true, returns 0;
> + * @mode = SMP_CFM_BEST_EFFORT: skips CPUs with previous pending requests,
> + *     returns 0 and *mask unmodified if no CPUs are skipped,
> + *     -EBUSY if CPUs are skipped, and *mask is the set of skipped CPUs

Please convert those comments to real kernel-doc format.
(Documentation/doc-guide/kernel-doc.rst)

> + */
> +int __smp_call_function_many(struct cpumask *mask, smp_call_func_t func,
> +			     void *info, int mode)
> +{

thanks.
-- 
~Randy