Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbWJQTnY (ORCPT ); Tue, 17 Oct 2006 15:43:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751195AbWJQTnX (ORCPT ); Tue, 17 Oct 2006 15:43:23 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:4113 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S1751232AbWJQTnX (ORCPT ); Tue, 17 Oct 2006 15:43:23 -0400 Date: Tue, 17 Oct 2006 15:43:22 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Cornelia Huck cc: Greg K-H , Duncan Sands , linux-kernel Subject: Re: [Patch 4/4] Driver core: Don't fail attaching the device if it cannot be bound. In-Reply-To: <20061017182536.48c8cb91@gondolin.boeblingen.de.ibm.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 21 On Tue, 17 Oct 2006, Cornelia Huck wrote: > On Tue, 17 Oct 2006 12:04:28 -0400 (EDT), > Alan Stern wrote: > > It looks odd to test the value of ret when you've just crashed the system > > if ret < 0. You probably should change the BUG_ON to a WARN_ON or > > something similar. > > OK, WARN_ON is probably better (but it should never happen anyway). > Updated patch below. Yes, I like this one better. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/