Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2842609pxb; Mon, 19 Apr 2021 15:46:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNvwUnE5+I4iZEA5yTZVNh7T6+a7w/tckqMFDQg91SEaQR4fyh6vfyzlFDlmTal0oVevyy X-Received: by 2002:a17:90b:78d:: with SMTP id l13mr1547455pjz.182.1618872393843; Mon, 19 Apr 2021 15:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618872393; cv=none; d=google.com; s=arc-20160816; b=S3f9AQh63gLdTDWy8T2bX83qSNDn8weLjvF7623gONXqo/7qsIwbzGm+YkYICLqWZG ULgS9LQ1Zda+ynvLz0i71SkFiaRSjoX6bp3CVKGa1Tgd8kkXddUqCZANJPBRa/HpVrSK GQIuasvjK4DLZ87eP4l1TR8AbX0yPb3xb4g/f/yqlbXcED9lMsDjTSX1bW6QUFhNAIrf O71SGdeXgFN55rarA/WzavWizSE14vmSu8B9aJ3MRZiSsnIQPbY1u0wdNUQDRCtVK5qa hF06tcy4Q2+KohW7sTl0Gbb54899/aKjJDGXE+t6SwyvZ3HIvYY/N8xeEm5lODjJjlIx CUoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=L1CmsPullNlKRGxad0wVdxfBFzlJq+hzOnlE8hOLlhY=; b=ELFrgSvb3eOalZVNQyVTNRozQZd14DJxg4yqcuq8u1/g0bIy/FBfyarmfk/tktO8eE MRmUeAAG6esMYzQtmmDAY5QzW+IcV6AuZGCyoM0bCuMqQiN/Bn+L32O/KjAo9EqlEuIV OH1HQ0UMAfoTVM8M8Ga19NHRguFK8VhJD1xto7rk6AiKG49E215QeyQIdPnUCJavlW0T ZMjeSbm5de01v27E/Tr858zA59JSaEbWAVxu6FN6tcuue0LoJIsIVmMz3pHKk9N4FKf+ xYvUsmX+99NLRnb4gRLpVseXXGNIF6QsFEQFKrfQKrdw/LEr5yVyQWMkIAg5DGxpwVk6 BFGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kx6si964429pjb.72.2021.04.19.15.46.21; Mon, 19 Apr 2021 15:46:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229799AbhDSWqS (ORCPT + 99 others); Mon, 19 Apr 2021 18:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhDSWqR (ORCPT ); Mon, 19 Apr 2021 18:46:17 -0400 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34A83C06174A; Mon, 19 Apr 2021 15:45:47 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 512B14F40E343; Mon, 19 Apr 2021 15:45:46 -0700 (PDT) Date: Mon, 19 Apr 2021 15:45:45 -0700 (PDT) Message-Id: <20210419.154545.1437529237095871426.davem@davemloft.net> To: aford173@gmail.com Cc: netdev@vger.kernel.org, aford@beaconembedded.com, geert@linux-m68k.org, sergei.shtylyov@gmail.com, kuba@kernel.org, andrew@lunn.ch, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ravb: Fix release of refclk From: David Miller In-Reply-To: <20210417132329.6886-1-aford173@gmail.com> References: <20210417132329.6886-1-aford173@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Mon, 19 Apr 2021 15:45:46 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adam Ford Date: Sat, 17 Apr 2021 08:23:29 -0500 > The call to clk_disable_unprepare() can happen before priv is > initialized. This means moving clk_disable_unprepare out of > out_release into a new label. > > Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk") > Signed-off-by: Adam Ford Thjis does not apply cleanly, please rebbase and resubmit. Please fix the formatting of your Fixes tag while you are at it, thank you.