Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2847825pxb; Mon, 19 Apr 2021 15:57:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJMS2sp4pwwpI5H2JOvWQqCwkpgDwUEr7Hwa25rslMsUjApIYeBJqCA5ZS27KHwBUIGU8R X-Received: by 2002:a17:906:6d15:: with SMTP id m21mr6522432ejr.34.1618873055151; Mon, 19 Apr 2021 15:57:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618873055; cv=none; d=google.com; s=arc-20160816; b=o3HtoWoUPjLvdRMPyf2qf7EzhW1xk3qLbPZhPX8bWRUKiXsxjKN8jqEl/xtLYj0gU3 cTQaKk8vivw8fk6TGQL01U5sQDb1m7xae8HalupLY1jBn5V0yQVj7qAXEdgEv6P5IqvH nOQ2DpKgMDZoc6dD3uesSDNA7ANG+dnhUrjHmEF6rL/pYgXKkDdUA6LOZH16ZSTMb5Sf pFzdQzGLx+rzGsPBTDqtFk0mAioYJSj22z2uDc3S7biI4VGMRivvPOnuZzmPuUGjNUHU goh6lMBEKgAotwgbr8t0OBGIKFBXqYxC7sBxu6AQCf1TlLFWWvFdPopngTTXlHlX88Md rkQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rXvOa2vhLxgteuwROnjXnJNpH30+jnf9gvFzYDgEgi8=; b=as8ZWrFYmAOjfgoBgqVewKT3jlIXtUJqfPLxN74xbSVG1wYAJs0sREw6I44UsFLSLr VSzRorMyasO5bKIvCpAuRITLXJzGq/rPO9dXWkDWzHrfqzNL1W/5MgKMMrAUsmgoCnnn 36dU12savWf1JQ0F24JT0BBsrMOiSLcQK+pmKsksXCQLh2lG89rlpkrvODic3wRiJg71 utKb6E+IJwYudz4WJXvkH7tv8K/OgTNF1beeQj9BfX7xHEoN9HFN+Qri1XzfxsVnAXvG CY7O/oa3osjFNM2iKY1Qp5kKT+tvCOo71KE4xLjQhvpV/GgexS6CfcCpO4CuFLTiWIUu ktUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AgEsiQe6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si12462551ejk.382.2021.04.19.15.57.12; Mon, 19 Apr 2021 15:57:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AgEsiQe6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230488AbhDSW4X (ORCPT + 99 others); Mon, 19 Apr 2021 18:56:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28514 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbhDSW4Q (ORCPT ); Mon, 19 Apr 2021 18:56:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618872946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rXvOa2vhLxgteuwROnjXnJNpH30+jnf9gvFzYDgEgi8=; b=AgEsiQe6+c01ia7UuqaGbdAAd0Vl27OY/CS0B3ZdG7TbDI6J22bkFsLBdpEAAQvtyV6kun tU2xxdpDUPY6ushOQmlZNRQMuJeDkssig6GkBJyHcrb6gO8LI3pUmcbLd4sFL1zL38nGw7 O+ZK8J++OUlFq4hQbrMOPrbbfbcjmfY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-t7lRGv6PMXia-qAM3eMBaw-1; Mon, 19 Apr 2021 18:55:42 -0400 X-MC-Unique: t7lRGv6PMXia-qAM3eMBaw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CAB281744F; Mon, 19 Apr 2021 22:55:40 +0000 (UTC) Received: from Ruby.lyude.net (ovpn-119-153.rdu2.redhat.com [10.10.119.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3B795C1CF; Mon, 19 Apr 2021 22:55:38 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Jani Nikula , Rodrigo Vivi , Thomas Zimmermann , Thierry Reding Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 02/20] drm/dp: Add __no_check to drm_dp_aux_register() Date: Mon, 19 Apr 2021 18:55:04 -0400 Message-Id: <20210419225523.184856-3-lyude@redhat.com> In-Reply-To: <20210419225523.184856-1-lyude@redhat.com> References: <20210419225523.184856-1-lyude@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we're about to make it so that drm_dp_aux_init() can fail (and thus - should have it's return value checked) - we should require that callers of drm_dp_aux_register() also check it's return value since drm_dp_aux_init() can be called from there. Signed-off-by: Lyude Paul --- include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 1e85c2021f2f..e44b0ee7b85e 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -2010,7 +2010,7 @@ bool drm_dp_lttpr_pre_emphasis_level_3_supported(const u8 caps[DP_LTTPR_PHY_CAP_ void drm_dp_remote_aux_init(struct drm_dp_aux *aux); void drm_dp_aux_init(struct drm_dp_aux *aux); -int drm_dp_aux_register(struct drm_dp_aux *aux); +__must_check int drm_dp_aux_register(struct drm_dp_aux *aux); void drm_dp_aux_unregister(struct drm_dp_aux *aux); int drm_dp_start_crc(struct drm_dp_aux *aux, struct drm_crtc *crtc); -- 2.30.2