Date: Tue, 17 Oct 2006 16:33:39 -0400
From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Andrew James Wade <andrew.j.wade@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       hch@infradead.org, Al Viro <viro@ftp.linux.org.uk>,
       linux-fsdevel@vger.kernel.org, Pekka Enberg <penberg@cs.helsinki.fi>,
       ezk@cs.sunysb.edu, mhalcrow@us.ibm.com
Subject: Re: [PATCH 1 of 2] fsstack: Introduce fsstack_copy_{attr,inode}_*
Message-ID: <20061017203339.GA30847@filer.fsl.cs.sunysb.edu>
References: <fe7c146c6457a4b288ab.1161060147@thor.fsl.cs.sunysb.edu> <Pine.LNX.4.61.0610171237220.22888@yvahk01.tjqt.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.61.0610171237220.22888@yvahk01.tjqt.qr>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 43

On Tue, Oct 17, 2006 at 12:40:31PM +0200, Jan Engelhardt wrote:
> 
> >To: null@josefsipek.net
> 
> (Superb idea to prekill any Cc, re-adding them)
 
Yeah, I like to test the emails but I accidentally sent them. From now on,
no testing :)
 
> >+void __fsstack_copy_attr_all(struct inode *dest,
> >+			     const struct inode *src,
> >+			     int (*get_nlinks)(struct inode *))
> >+{
> >[big]
> >+}
> >+
> >+/* externs for fs/stack.c */
> >+extern void __fsstack_copy_attr_all(struct inode *dest,
> >+				    const struct inode *src,
> >+				    int (*get_nlinks)(struct inode *));
> >+
> >+static inline void fsstack_copy_attr_all(struct inode *dest,
> >+					 const struct inode *src)
> >+{
> >+	__fsstack_copy_attr_all(dest, src, NULL);
> >+}
> 
> Do we really need this indirection? Can't __fsstack_copy_attr_all be 
> named fsstack_copy_attr_all instead?

I suppose it could. There is no API-breakage to avoid.

Josef "Jeff" Sipek.

-- 
Computer Science is no more about computers than astronomy is about
telescopes.
		- Edsger Dijkstra
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/