Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "ruslan.bilovol@gmail.com" <ruslan.bilovol@gmail.com>,
        "jbrunet@baylibre.com" <jbrunet@baylibre.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH 1/2] usb: gadget: f_uac2: Stop endpoint before enabling
 it.
Thread-Topic: [PATCH 1/2] usb: gadget: f_uac2: Stop endpoint before enabling
 it.
Thread-Index: AQHXNPDk4IS+DQ4fDUKw1PIKLUko/Kq8mYyAgAAuUMA=
Date:   Tue, 20 Apr 2021 03:56:25 +0000
Message-ID: <BYAPR07MB5381F9748155F73732090E87DD489@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20210419075053.28467-1-pawell@gli-login.cadence.com>
 <20210420010846.GA6408@nchen>
In-Reply-To: <20210420010846.GA6408@nchen>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 02b9a3ff-3da0-4f6d-7fb8-08d903b044fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 03:56:25.4607
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nkkMxsD7VZndVg/PvlapnZKUcAjbmI4VqiryT/UifQx1bu+SZVyjeQ2x6AGQB0VTyLwQO6fBGyD8iepvJaZdqRawZTFyK2qNrtk3QtVo28I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4152
X-Proofpoint-GUID: 3rxadWuglk301Lf13eAYqVD0tvEHKgta
X-Proofpoint-ORIG-GUID: 3rxadWuglk301Lf13eAYqVD0tvEHKgta
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-20_01:2021-04-19,2021-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 malwarescore=0
 mlxlogscore=751 impostorscore=0 clxscore=1015 adultscore=0 spamscore=0
 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0
 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104200027
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On 21-04-19 09:50:53, Pawel Laszczak wrote:
>> From: Pawel Laszczak <pawell@cadence.com>
>>
>> Patch adds disabling endpoint before enabling it during changing
>> alternate setting. Lack of this functionality causes that in some
>> cases uac2 queue the same request multiple time.
>> Such situation can occur when host send set interface with
>> alternate setting 1 twice.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/gadget/function/f_uac2.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/f=
unction/f_uac2.c
>> index 9cc5c512a5cd..7d20a9d8a1b4 100644
>> --- a/drivers/usb/gadget/function/f_uac2.c
>> +++ b/drivers/usb/gadget/function/f_uac2.c
>> @@ -890,17 +890,17 @@ afunc_set_alt(struct usb_function *fn, unsigned in=
tf, unsigned alt)
>>  	if (intf =3D=3D uac2->as_out_intf) {
>>  		uac2->as_out_alt =3D alt;
>>
>> +		u_audio_stop_capture(&uac2->g_audio);
>> +
>>  		if (alt)
>>  			ret =3D u_audio_start_capture(&uac2->g_audio);
>> -		else
>> -			u_audio_stop_capture(&uac2->g_audio);
>>  	} else if (intf =3D=3D uac2->as_in_intf) {
>>  		uac2->as_in_alt =3D alt;
>>
>> +		u_audio_stop_playback(&uac2->g_audio);
>> +
>>  		if (alt)
>>  			ret =3D u_audio_start_playback(&uac2->g_audio);
>> -		else
>> -			u_audio_stop_playback(&uac2->g_audio);
>>  	} else {
>>  		dev_err(dev, "%s:%d Error!\n", __func__, __LINE__);
>>  		return -EINVAL;
>
>To avoid this, you may use prm->ep_enabled to judge if the endpoint has
>already enabled.

Such condition is as first instruction inside u_audio_stop_playback->free_e=
p  function,
so we don't need duplicate it here.

>
>--
>
>Thanks,
>Peter Chen

--

Regards,
Pawe Laszczak