Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3100468pxb;
        Tue, 20 Apr 2021 00:04:31 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw6GafC18kRjiG+9ctLI7tPCxL8OumHpKonj91NOq9MyuI7bXF8SvSMi8P7G5I7e5Dzt/Nm
X-Received: by 2002:a17:906:d109:: with SMTP id b9mr7496773ejz.548.1618902270813;
        Tue, 20 Apr 2021 00:04:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1618902270; cv=none;
        d=google.com; s=arc-20160816;
        b=0zLOisS6b4URdb+QZePNpL43n1KaXTseQUF2QksK65fV85I7NiKcs6aGd8azwRLwrh
         QwzZz9uDOgxq1wapRWWUuz2p3EsDQK8Lg9Cagm+7MGlp4fqXfaHFc2Lmm9Vba3PJZrlZ
         mdq77NcJc/oaD+LIE1hAvu6DnyioSAPIG/KlynPFFfz8dBXC8iskKT75I1O0oZPoaVVb
         xnrim9/LxiJzRMGRrP0fQ9H5sz1XYVQmXi+1OBE0AJe504ziOehT94ltx9Usg5mx/dRE
         oTJMRD+fafm72lzZyRA/9Dd/jqs+7A9eh9aux6/zgJ1axdVdSP03m2uw5vjstI7KrAif
         Jvdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=8Oihx25ixLmgK896s6BkBU4Zy4ZTSxg7BY07q9IT2hQ=;
        b=ZPuGsFn68bO1LeveMhjqY8Qu12Aj1nfdaP110RIH/8uyvXDAH/DQcvxJxKvK8AEHAu
         l9OBMPNt/YH1IifQ/i4iKimpUwwowsXsDwWrSCRJvdsh9Kq9MttyeKqYEtbn8XLS8c9+
         JUVJrFodrIb97/s4CeKnGiCT+8zXZvnQFogbp3PxgBy0hdX6SfXKnu9ppOggKucF0H2L
         A1w1btYxMIKWPwD1CBDX/Kasfwqnc64f+CPgarD6b1gCRzalPix0ztcTpeJpBa/Ji7Ww
         M4CoOj21QdIQ9eEoZniQo6yyZ+cSGCwHoYDJI9k4T9BWHaLYspZbM5yfs66vjVHtknsY
         yjGw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hFqirIfh;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c15si15092869ejr.633.2021.04.20.00.04.07;
        Tue, 20 Apr 2021 00:04:30 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hFqirIfh;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230315AbhDTHD0 (ORCPT <rfc822;lists.md@gmail.com> + 99 others);
        Tue, 20 Apr 2021 03:03:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37360 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229577AbhDTHDZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Apr 2021 03:03:25 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7417C06174A;
        Tue, 20 Apr 2021 00:02:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=8Oihx25ixLmgK896s6BkBU4Zy4ZTSxg7BY07q9IT2hQ=; b=hFqirIfh+nlo9lCAUemEoOwmcU
        ZMdFNj8RgdzR2qM5APmrrVtR2OeTcERwNN38u6nFxezVx5GJo/xAtYA7HD2DxH0kqehLO52bXBwLe
        4/yxCWMoy1FXMYDGSBjvTS3E9tGAd58v9GOpMqgE+YHl2Vwv1VS5Gu+Zq+IQHvZlk/l2dqxTnG4FG
        MHw2JbqYRC17ffhqd08MnBFxZTB/JNwajHFljefrZWjdnheFvlycOhNYNrNFZHVPMf0UJTWMTKfYK
        P8u11hg1IsH0zaSL1KL7F3EnxipCucT9Xw4ZAr0PB8sF+LfvSOvdTbzuzkN4XE+OubYIRqGoz37Mw
        Jw7zA3AA==;
Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux))
        id 1lYkO1-00Eplv-KX; Tue, 20 Apr 2021 07:01:54 +0000
Date:   Tue, 20 Apr 2021 08:01:29 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Enrico Granata <egranata@google.com>
Cc:     mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
        stefanha@redhat.com, axboe@kernel.dk,
        virtualization@lists.linux-foundation.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature
Message-ID: <20210420070129.GA3534874@infradead.org>
References: <20210416194709.155497-1-egranata@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210416194709.155497-1-egranata@google.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Just to despit my 2 cents again:  I think the way this is specified
in the virtio spec is actively harmful and we should not suport it in
Linux.

If others override me we at least need to require a detailed
documentation of these fields as the virto spec does not provide it.

Please also do not add pointless over 80 character lines, and follow
the one value per sysfs file rule.