Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5/7] mfd: sec: Simplify getting of_device_id match data
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Support Opensource <support.opensource@diasemi.com>,
        Lee Jones <lee.jones@linaro.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
        patches@opensource.cirrus.com
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <a65318f6-1465-a35c-a987-8b833311ef3a@samsung.com>
Date:   Tue, 20 Apr 2021 09:12:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0)
        Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <4a5e80c0-653e-a4d6-630e-0d75e3779f6d@canonical.com>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20210419081726.67867-1-krzysztof.kozlowski@canonical.com>
        <CGME20210419081852eucas1p29d7904aa73d6621feb03cb24a91ed95d@eucas1p2.samsung.com>
        <20210419081726.67867-5-krzysztof.kozlowski@canonical.com>
        <64fb91ae-c754-fb25-0ef7-17b2f1b8a1e4@samsung.com>
        <4a5e80c0-653e-a4d6-630e-0d75e3779f6d@canonical.com>
Precedence: bulk

On 20.04.2021 09:03, Krzysztof Kozlowski wrote:
> On 20/04/2021 07:25, Marek Szyprowski wrote:
>> On 19.04.2021 10:17, Krzysztof Kozlowski wrote:
>>> Use of_device_get_match_data() to make the code slightly smaller.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>    drivers/mfd/sec-core.c | 9 +++------
>>>    1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
>>> index 8d55992da19e..3126c39f3203 100644
>>> --- a/drivers/mfd/sec-core.c
>>> +++ b/drivers/mfd/sec-core.c
>>> @@ -10,6 +10,7 @@
>>>    #include <linux/slab.h>
>>>    #include <linux/i2c.h>
>>>    #include <linux/of.h>
>>> +#include <linux/of_device.h>
>>>    #include <linux/of_irq.h>
>>>    #include <linux/interrupt.h>
>>>    #include <linux/pm_runtime.h>
>>> @@ -324,12 +325,8 @@ static inline unsigned long sec_i2c_get_driver_data(struct i2c_client *i2c,
>>>    						const struct i2c_device_id *id)
>>>    {
>>>    #ifdef CONFIG_OF
>>> -	if (i2c->dev.of_node) {
>>> -		const struct of_device_id *match;
>>> -
>>> -		match = of_match_node(sec_dt_match, i2c->dev.of_node);
>>> -		return (unsigned long)match->data;
>>> -	}
>>> +	if (i2c->dev.of_node)
>>> +		return (unsigned long)of_device_get_match_data(&i2c->dev);
>>>    #endif
>> Does it make any sense to keep the #ifdef CONFIG_OF after this change?
> Good point, it was only to hide usage of of_device_id table.
>
>> I would also skip (i2c->dev.of_node) check, because
>> of_device_get_match_data() already does that (although indirectly).
> First, the enum sec_device_type would need to be changed so it starts
> from 1, not 0. It's because the value returned by this function is later
> assigned to that enum and there is no way currently to differentiate
> between NULL and S5M8767X.
>
> Second, it wouldn't make the code smaller;
>
> unsigned long data;
> data = of_device_get_match_data(&i2c->dev);
> if (data)
> 	return data;

Then maybe one should go further and remove legacy, non-of based 
initialization, because it is not used at all. This will simplify it 
even more.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland