Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3109627pxb; Tue, 20 Apr 2021 00:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxICF8RRngvQFAfnB1L49ot2x54A9J8eMisUc8XVWvqfbe6LWXTDRbjPAY/s3jqJ28bI5V X-Received: by 2002:a17:90a:a604:: with SMTP id c4mr2023900pjq.81.1618903156561; Tue, 20 Apr 2021 00:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618903156; cv=none; d=google.com; s=arc-20160816; b=Oq+232Ubx/3HdXoxoxlvqCQQIgLEF3CKL0Rffdsx7eqN55FJn13AIO1k/XPDiDrb/K FkZs9NpKt9IhBW34ecSd6AjYtgCRIYVA4Yk42pFy7H8NeZSE/WJWL8wJIntLnwGZEfms hstW8ORGSjvsUcpiPj2UOaWejHq+Cjtt9AGsJjvcjiRi8pmD9I8Zjm/2OZq3OSm7yi1v 1BtRQwS1JDdDPAGyBcb04uQU8E01zXm5sUCe+BgXTRlMNJiiO8XPSgjR2DmYbYfnGIEb Kh+xk8NfiUvmcSmvUKo64czxrgx/a7zpljCoJz3OKDJWRe0SSFsqKmvd6mBi/1JlyTC6 IrRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZqxtKsnYkGXbb93cI6E5KoqAYVAovqCHPPS4tf6kc/0=; b=tgBSkLvGt0WzN7cjn2sF3YLqu/Py6A6s8jBUsF9TzacBwPFeUe7iirVfSaI5WPCBfe dKCmfcarAUrz3C5N5Ew0yvxPZiZAEu9WFR+D11Ua7zWdiw5Cv9vImNiJ29zIv+IIfebK iyNC01ZZ7PXp7wFsOO0qp98/loNsqothswRmBUJV0WaDL2FfLOvrbm38JtkUbA3VmYOU qYApEXZZI7aMQhxvTWumZ/I9FNmjrlFYKTvaRcjfyHx0pxWQlpW++y5nu4o1j4TQTUZc PKUlxcKrGIgpTY/rcIwrgOZ5z3DrBuANMeeFRUqmJmEmZGxpa668DtjqzzwZHyojJCmO 2G9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KWxZ24FV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 9si21229072pll.139.2021.04.20.00.19.02; Tue, 20 Apr 2021 00:19:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KWxZ24FV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbhDTHS6 (ORCPT + 99 others); Tue, 20 Apr 2021 03:18:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:55306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbhDTHSw (ORCPT ); Tue, 20 Apr 2021 03:18:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F34E61154; Tue, 20 Apr 2021 07:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618903100; bh=lGnIOSzz+/Tjw1GF9ijhnq+D7vLmF70UBSYAWWr7KBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KWxZ24FVI3gyv5P4ai5efO0VZxEuTziQhwoXJsiYtXRXbLrhydWztgKVG2dz9j/K2 tM6xKW6/bIGx7rDSFdsFhN811HMGl7T7LlfJQkCsBtRDOZl5pb4grkSGFqTIVbL8JJ uEnqCFxKmAd/2nypZ79/7/yCTLGGFQMjGnuynHEg= Date: Tue, 20 Apr 2021 09:18:18 +0200 From: Greg KH To: Aditya Pakki Cc: Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: be2iscsi: Reset the address passed in beiscsi_iface_create_default Message-ID: References: <20210407002445.2209330-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407002445.2209330-1-pakki001@umn.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 07:24:45PM -0500, Aditya Pakki wrote: > if_info is a local variable that is passed to beiscsi_if_get_info. In > case of failure, the variable is free'd but not reset to NULL. The patch > avoids security issue by passing NULL to if_info. That is just not true at all. Stop submitting patches that you know are invalid. Your experiment is not ethical, and not welcome or appreciated. greg k-h