Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3111652pxb; Tue, 20 Apr 2021 00:23:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT3MUL6Os6vx5yzI7gT6Az5NbBeg4cC8nv/mtcNYChjDoYBDZZV903CyvYbNP+qnjo/ViP X-Received: by 2002:a17:90a:4b8c:: with SMTP id i12mr3497056pjh.66.1618903384798; Tue, 20 Apr 2021 00:23:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618903384; cv=none; d=google.com; s=arc-20160816; b=pgBICy/dIJosGXxOfEEXb933SCPrSnwfvXZVOhbJ/ukFvFhhD2mUVt9QhKPj9+Ph6D 6FuIrKNVXy1nOT8jhKiqEDZgER3wQVcH3Xs5EUfYGyyO/6pcA/4i/6C9BKWvSn0ttJdu jEzL4n+SocgS58qTt4zMQMQdpwENL5ue7p+3UV2YjM49h+89CiuvcsPNO2fCYEeaw3Sb wdn0GksMFD1EyKlrntzy+09VZyYBNhE7rte2wBBniKZLIqadYcfGzBXyWLR+l0CEC9FA X6mSuCGnAXgpUYN+HYPJ1meaOvlNdn301INHGZ91G15aKuJmqAfdmdqD0J0KqR0W1JWj Kpwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XIh+31r+iVEBEr25FDkawRp8pAq9hUH4QG8xtGfBtQE=; b=EcxmipHyt8mjjv5u5kG3TyhpUHdXl6kXMiLevfhjN40URtkZNIbuyGFokoxQuEqIHO SK7iqRZigEqYLPohdpK/xd7k/C0xEspjCMzOab9hX9naFS8ypyyOhDEm0jaW5sw/86NY axn1BqYY3N9uN1jGxSGUo1rSxjp1th2UaaDrZzngAdF/9eKsv44rgY9zmgdTo/rYgC45 p0hRWTJmcGK9ubhOVJI+5WXSf4nvUxA0TQ6iQdqbv5op1ilBITNJaBnkE5qHnNPkai5j xSEaFSv3orY1TrunHyTUmq+2e6sgR+2DBf69exNgSXIzAx5qAraCoAaGXbe2BaeOJfaG Jr/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="X/D6S8ty"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l132si1950877pfd.116.2021.04.20.00.22.52; Tue, 20 Apr 2021 00:23:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="X/D6S8ty"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbhDTHWL (ORCPT + 99 others); Tue, 20 Apr 2021 03:22:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:58168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbhDTHWK (ORCPT ); Tue, 20 Apr 2021 03:22:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF76C613B8; Tue, 20 Apr 2021 07:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618903299; bh=HgiZFCdzKF6IiyU4Kp6UvES9KDEbhI3jeiuc8ALbx64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X/D6S8tyQEHjH/Y6UzKkNRmT3eRWUO4tkAmwPb9Ra1xSpFZo6p3WKj8FfDkUlpawI 11UCK4Jyz2qXPnX1xKAla84nByzYyAacvj+aXM7n5Ymv1VPHCasWeBiK7KVIwLBld3 33Y/49B+c/hXyeEWursBgfm6TSEEMZzMvajdzBjQ= Date: Tue, 20 Apr 2021 09:21:36 +0200 From: Greg Kroah-Hartman To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Aditya Pakki , Santosh Shilimkar , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.10 042/103] net/rds: Avoid potential use after free in rds_send_remove_from_sock Message-ID: References: <20210419130527.791982064@linuxfoundation.org> <20210419130529.251281725@linuxfoundation.org> <20210419212930.GA6626@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210419212930.GA6626@amd> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 11:29:30PM +0200, Pavel Machek wrote: > Hi! > > > [ Upstream commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 ] > > > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > > is freed and later under spinlock, causing potential use-after-free. > > Set the free pointer to NULL to avoid undefined behavior. > > This patch is crazy. Take a look at Message-ID: > <20210419084953.GA28564@amd>. Or just look at the patch :-). You are correct, everything submitted from this author and domain recently was done as a "research project" to see if they could mess with kernel maintainers and slip in pointless changes to the kernel. Not acceptable at all... greg k-h