Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3156624pxb; Tue, 20 Apr 2021 01:41:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlDZ7nzNBYsuT12izro+b8G8ql5OPabO1U6MEeQNTTIDQCofazqf5wxfCoYMy1vyPmPibo X-Received: by 2002:a63:f30b:: with SMTP id l11mr3797398pgh.129.1618908095193; Tue, 20 Apr 2021 01:41:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618908095; cv=none; d=google.com; s=arc-20160816; b=0NOKnK7FkahDra9z4MWEnZV+yV08b+PfzGbhro14dsxShnHLot1M4IpSHvWYcZlH8x 6+t4pWgpxGnUTaH4LLQcPK6rRZCuTEZkw/rpAe/2NPe9Pp66bJYaU6aKt+B+o9Ad/rEm RwqHCGvlWLFzLnb6CsVtDGbV2fXA9EaCKSR4RGkd0f6213RgCf70erBFGLsT3TrAG5c8 N+ClslXOqtMO49r7Yb6JON/jaTkpMnPfsXe4CFV1+0tZffgPFzgcIOorh2goObyPaC8k zaPA6eqQQseTMcpM6xbEdIDZM5VfZvG5TXUAk0hq90ZI4u7OPG5SZ/Y15hi+jH6WhlkE hdlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=zB438UsN4r9986PE2xEGkDVIweUkvDdpBp47AfbjynM=; b=v/GH9bxBsj6+8dtQ+PKRZFuOOKu3sFLWrUs3dwsWJ3H1a7o7tJ2ICAisd6HXw23xLF El0DKdWTRqel2mCOaxhanhB10IWgEZy/aUJkXKhAsSm6tKbB21lXY7r3djJaSKZm/QqB lwj9+vGi1E74Mf9u3bNwyWbdXUMacFskVLWmndHBc2M1QKkVHca0RVWB3Zlku3sIyD2Y 2nLgEO9F4akT2ID3ZAA50vWVlE8AiAyvxonMDrPwAFXQGc1Gin5npjXPeB+hm8asnZPo USwsjwjzjQZi1TxGpuCAQ+N5BL6L1nFyLEix3zOw2B2S8Os5zocRQOF7sOWJMRPfM4Ay rSyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bei4g08q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si3082336pjj.34.2021.04.20.01.41.23; Tue, 20 Apr 2021 01:41:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bei4g08q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230475AbhDTIlT (ORCPT + 99 others); Tue, 20 Apr 2021 04:41:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27600 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbhDTIlT (ORCPT ); Tue, 20 Apr 2021 04:41:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618908048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zB438UsN4r9986PE2xEGkDVIweUkvDdpBp47AfbjynM=; b=bei4g08qL7FL1WCCniujyQSbFO+Ayow4K377cRJq2y5vWNMFj2UHlVA96gadEVHbRnwsTl GytxwnHRJ3bvqfWvVtDEA64eLmBUDhjwcAy9ThSInI2mfb4y4gYisgyjYtq4OwhSSqxqNb 0JllmMKIApq7u6sQ1KcyEnipu9pEoBY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-566-f_UzkOA3MkGNMwpZtscISg-1; Tue, 20 Apr 2021 04:40:46 -0400 X-MC-Unique: f_UzkOA3MkGNMwpZtscISg-1 Received: by mail-ed1-f70.google.com with SMTP id l22-20020a0564021256b0290384ebfba68cso8885191edw.2 for ; Tue, 20 Apr 2021 01:40:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zB438UsN4r9986PE2xEGkDVIweUkvDdpBp47AfbjynM=; b=OIKmWBgqK/E97h/u+uTmezZn9xuCGGJnLn+4E/9QD8d8ViP/T9A7tabvL7l8Jt5SHy 89cinwLZvvZk3ko+9KUzVH7wZWyqPZcCP2H2aT+mhWGdFO2uqMX5vPakbUcaRz2EwHsm 5I+c8L8n2pTQVIBwhBJEX8M8dGjrmQ+zjjqK27V3b0aRqEhVC3ZVcPZ1NuPqHo6ohO36 WmAzOPzNWUUYvXpaK+CaIX4o8KJzEF4GTIqTnTY/XY3b7QdfhgOGyH9s16aCmf0fyZAF pO3ijHkKk7rLSTKbOSPe8AJfWDOf5E/wWAmlCDDXQO+1mMyPBY3SeeMTMvpn+eLSgyx/ 80xA== X-Gm-Message-State: AOAM530AbfsVnBIP22tgmGIY0gCg8acuZFE8VLOX0Zaq4joFBoDXQvCQ Ad800tHvYwZUfQB1OmKg6Ti4g53F9hsirp4aX0jkNVDGgJ3biAKZvEbGl7xh42X2TKfRIU2ZZM2 iv+QIOVrqFVGyWwntpUlwr14C X-Received: by 2002:a17:906:8a79:: with SMTP id hy25mr26634052ejc.461.1618908045436; Tue, 20 Apr 2021 01:40:45 -0700 (PDT) X-Received: by 2002:a17:906:8a79:: with SMTP id hy25mr26634034ejc.461.1618908045217; Tue, 20 Apr 2021 01:40:45 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n15sm5177405eje.118.2021.04.20.01.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 01:40:44 -0700 (PDT) Subject: Re: [PATCH v13 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command To: Ashish Kalra Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, bp@suse.de, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, seanjc@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com References: From: Paolo Bonzini Message-ID: Date: Tue, 20 Apr 2021 10:40:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/21 17:55, Ashish Kalra wrote: > + if (!guest_page) > + goto e_free; > + Missing unpin on error (but it won't be needed with Sean's patches that move the data block to the stack, so I can fix this too). Paolo