Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3158681pxb; Tue, 20 Apr 2021 01:45:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9kO90RqR53CXY6hH1vUV/HTHU0JZr9z2sW5GOq8wESvEWJi7Z/uUaZ//e7h33VODr2+ZZ X-Received: by 2002:a63:ed58:: with SMTP id m24mr16320369pgk.248.1618908304574; Tue, 20 Apr 2021 01:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618908304; cv=none; d=google.com; s=arc-20160816; b=HIDnB/txZd9rF8JvsUy8Ww9vwAfYcDekl3n45KjiylnkX7cbTsULbyGxbMmt3kyW8s JS8MdpzoYjRrmCz6tERD95XNgVaWOZKt8nd2l/L+TJCl0FuKlR+I8nIeywyCtrr1EF35 KrOZYLsGb3gZBRX1UDo+6wJO6i7TcP2MwSXG5pGsUG9w6tv13+l7B4sKzp7yKOunwNV0 CJem6is9KWeDmlVexVFM8vZd0AoRvh4COD1NGQ9lZUPfJ7XbwrzVryGLRX4SzC8VWlIq 9VyThayNPHWXf5/0d5oK0UbKWS/iyB6RKvy4mXPVQmIi3yFgEO1cHY2rTqrt2y5dEQe4 kj/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject:sender:dkim-signature; bh=BwiYHNH+mzbQq1eWxaZN8VLk/WYh0GnoED1nQWvWtlM=; b=nRjizx8E+AYBZVTm6C+FVghNquE1rTuSAladOY5Nl7Cb7bO2KHGhOS+w629ZnQJDiT Xb3qum1QXRTViKSBX8cMwC6XRCNmZ2C4VnIG0IIXpbgv008cZ5ZScIeVXUHTe93+uJhF d6RU10JCDquCZIXxtjISldQC6DK0lbw7i/KJjPzuIteaR0CBW9HbrMvaNISrkBcxP42o 3Wm3DEizkmtrYrQgzVXXvf9iwQsEgnocaKdhGHekmcy9Nk1H3YBlSkTV1kUdtybdm0Lc CWs4qDVuh1BWQqSCNUNPJEtnAIIMhp7JOlKmLHh31GPZzF8nTF7PJ4EkTQOujsg/61LF Dt1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mJHYEsy0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mz7si2786156pjb.152.2021.04.20.01.44.51; Tue, 20 Apr 2021 01:45:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mJHYEsy0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbhDTInk (ORCPT + 99 others); Tue, 20 Apr 2021 04:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230512AbhDTInj (ORCPT ); Tue, 20 Apr 2021 04:43:39 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3776C061763; Tue, 20 Apr 2021 01:43:06 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id i3so18351595edt.1; Tue, 20 Apr 2021 01:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BwiYHNH+mzbQq1eWxaZN8VLk/WYh0GnoED1nQWvWtlM=; b=mJHYEsy0lrq44tQ+HV9EvTSkNRw4inlVFLXWsZclHsxdHs82zS976sBpxS7NIhN2ol GPECx+bHIZBqp6PX/BPIprETq8ACwhe00CnhkhatuOVpLRtpLeXgf+McP4cLTvR0Ci43 j7jLt39ksPXVmJScAV9jUqCbVu2VI1HWEPp6sKIYANW0a3nN5L7DeR12QlYsRpwdJ/7G G9qSZWcUWWDSYallI4Q+mwgcsBa4t/9rFl3MFiAs0dk2tjjklZm1sty2kNbxep8o1Oaw nHO/Ltq4diyCeUzF9T/eeqWN7jBuorGKs5H42qHAcqBgBgcEjFS1v28rkCLjDwN4UT5L RoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BwiYHNH+mzbQq1eWxaZN8VLk/WYh0GnoED1nQWvWtlM=; b=q/lHnu4vHt+n8uVm3Y3PQIa9QxYUkZqrPvl9ALJNaSqI5GCGVgY1hcIeLefkO/TY17 tT8h9BK6K3Q7auTgJfJLXKkNNpgGTL8LEykJ4qqk1WkDyI87mhD53rMkMg2dfCs2ps+r Pq4/irMeHTrJzA4tKV9Sw2EFrrf9+m+Zf4H3QTbX1ikYZco9nrdKh2UE4NfXPwAEI4Wr zSCQHN+5zQa6odZlh/viZ2YJCM9fPXOFrUQgrSgATL6aBY3m+W+LDfkrOKyiqG8phILd uZX+Q5D/ZdATIWXOac9lUFm+6qk0dRw5NK59z28FIsLuBWYy/0HZ619BWeNePRRSTNT8 zPCg== X-Gm-Message-State: AOAM531WKChE7ErNVS41IkqahJuPIKykHKoeUEIcYOsd8sxMkBKTmg8l 8Pd6fLpDaPUOvumB0/wUZ/s= X-Received: by 2002:a05:6402:1109:: with SMTP id u9mr31265496edv.174.1618908185613; Tue, 20 Apr 2021 01:43:05 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id c13sm8995334edw.88.2021.04.20.01.43.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 01:43:05 -0700 (PDT) Sender: Paolo Bonzini Subject: Re: [PATCH v13 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command From: Paolo Bonzini To: Ashish Kalra Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, bp@suse.de, thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, srutherford@google.com, seanjc@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com References: Message-ID: Date: Tue, 20 Apr 2021 10:43:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/04/21 10:40, Paolo Bonzini wrote: > On 15/04/21 17:55, Ashish Kalra wrote: >> +    if (!guest_page) >> +        goto e_free; >> + > > Missing unpin on error (but it won't be needed with Sean's patches that > move the data block to the stack, so I can fix this too). No, sorry---the initialization order is different between send_update_data and receive_update_data, so it's okay. Paolo