Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Apr 2021 12:28:44 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Song Liu <songliubraving@fb.com>, Tejun Heo <tj@kernel.org>,
        kernel test robot <lkp@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/2] perf/core: Share an event with multiple cgroups
Message-ID: <YH6s3P/3hQxI21eO@hirez.programming.kicks-ass.net>
References: <20210413155337.644993-1-namhyung@kernel.org>
 <20210413155337.644993-2-namhyung@kernel.org>
 <YHhS6kjeA8AvcFgz@hirez.programming.kicks-ass.net>
 <CAM9d7civd59i4hquyxExQALcxOeDxk_ODpJwCRr-Rm3iMeahxQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7civd59i4hquyxExQALcxOeDxk_ODpJwCRr-Rm3iMeahxQ@mail.gmail.com>
Precedence: bulk

On Fri, Apr 16, 2021 at 06:49:09PM +0900, Namhyung Kim wrote:
> On Thu, Apr 15, 2021 at 11:51 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > > +static void perf_update_cgroup_node(struct perf_event *event, struct cgroup *cgrp)
> > > +{
> > > +     u64 delta_count, delta_time_enabled, delta_time_running;
> > > +     int i;
> > > +
> > > +     if (event->cgrp_node_count == 0)
> > > +             goto out;
> > > +
> > > +     delta_count = local64_read(&event->count) - event->cgrp_node_count;

From here...

> > > +     delta_time_enabled = event->total_time_enabled - event->cgrp_node_time_enabled;
> > > +     delta_time_running = event->total_time_running - event->cgrp_node_time_running;
> > > +
> > > +     /* account delta to all ancestor cgroups */
> > > +     for (i = 0; i <= cgrp->level; i++) {
> > > +             struct perf_cgroup_node *node;
> > > +
> > > +             node = find_cgroup_node(event, cgrp->ancestor_ids[i]);
> > > +             if (node) {
> > > +                     node->count += delta_count;
> > > +                     node->time_enabled += delta_time_enabled;
> > > +                     node->time_running += delta_time_running;
> > > +             }
> > > +     }

... till here, NMI could hit and increment event->count, which then
means that:

> > > +
> > > +out:
> > > +     event->cgrp_node_count = local64_read(&event->count);

This load doesn't match the delta_count load and events will go missing.

Obviously correct solution is:

	event->cgrp_node_count += delta_count;


> > > +     event->cgrp_node_time_enabled = event->total_time_enabled;
> > > +     event->cgrp_node_time_running = event->total_time_running;

And while total_time doesn't have that problem, consistency would then
have you do:

	event->cgrp_node_time_foo += delta_time_foo;

> >
> > This is wrong; there's no guarantee these are the same values you read
> > at the begin, IOW you could be loosing events.
> 
> Could you please elaborate?

You forgot NMI.