Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3243784pxb; Tue, 20 Apr 2021 04:05:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+k1SyHA12HAdZIU7JyPwcDQAJxhMEp1ZrIg8vLWHtc4cVPB5jy+bJVETodnuH1RwIq3/d X-Received: by 2002:a17:906:f9da:: with SMTP id lj26mr26279134ejb.98.1618916741529; Tue, 20 Apr 2021 04:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618916741; cv=none; d=google.com; s=arc-20160816; b=jWftpZI3WP1D835ObznOPg/e2I6Huv5EuhcGidNY7Ltcm8QchC0bxaFMmKMezd0meV 1CAg1T/laDaQx4QUWDv069r9YHsbNmpawrkLCtUfjN2kp12AXYzY6aOPvH8HOAnAnC8f Cq39B5SfgZPgNZ4ZMnBCFu3fDDgoRsoaYKVc1vC6jfhzCrXm04kMljqElHIFTdZISk7C TbYFN6PW9MukJ6Q2pQONCs0pahdfig3ti/WL7ls+CTyI8B3k6vlodqNKHlIMfdzOWG96 tnhVW955eKIrwytCv+4fp7rr1sFI50CUnMrUNvxrQXDRTSb/D4mTk83jaKfb2CyOEyjc ZWEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LtV7CncGgWbczJ5pJS0aGf6xtVkvJ4n6Wcq3KI7t+hs=; b=l47g5kQxLvmWWSKWHjkWM+gEHiaEOBzn7mnq4/VUjJX9qQQ+nfObHmWpJhMR/pt32t 1kI180lKxhwa4kKZ6dNgno1cFA39u7edB3P1XCZs/C2GVaJh5ZmKafqq6CjhPeoV/8EP 3bm4MQxmX7N472FAC6vO7RTW6LpTSDWS9gScdWOf/bXC8dyZ3l4hsXe4Jt7K0wiNMZYU a5HEuGIw/pC9zuDFQWVB4qM6JrZbPO8EC35wn4Uiaic0IhFwXZwURPlyC9+V5O72JAgh 8yvLL7VXeVeDhQiVPahlMI0KDOlQrYGWAbZJ2TLeXpKV0txj1HjUjTb56G11Pw+OCEJa Rsqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=kp7saIAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo13si14777973ejb.655.2021.04.20.04.05.18; Tue, 20 Apr 2021 04:05:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=kp7saIAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231747AbhDTLFA (ORCPT + 99 others); Tue, 20 Apr 2021 07:05:00 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:64722 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbhDTLE7 (ORCPT ); Tue, 20 Apr 2021 07:04:59 -0400 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13KAuvAJ017452; Tue, 20 Apr 2021 11:03:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=LtV7CncGgWbczJ5pJS0aGf6xtVkvJ4n6Wcq3KI7t+hs=; b=kp7saIAdK7NOIsggePDlhd5CGL274IiUz/IQRMpHsfAJ+vrAEpQ1tTiqgwTGddbaEqah 21h9NK4melT/Bei/pbn/KsO435G58VPBUUhj8d9EzULc4OYCODpGdNQgZw+IYWEACQQ7 hHU6FwHnELr4p55HpEZI+/zsYoRPIbtr3n4wHApviXnPmabQACAbvuOkz0IIfrwSoAuc cO8utFjhOvpF+9b+VqRoQC28o476a0JhSiirFbpwWZbrKwnVIPkrfA7oP2PTfspM51Dz H2yR2zD5PyckJWSPrIIOxkobh19625cZXx1spLZPxpxCh/aBmYSTljw7deNWjO6LtR7D Ow== Received: from oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 381dum85tx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Apr 2021 11:03:59 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 13KB3wIi139551; Tue, 20 Apr 2021 11:03:58 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 3809esejed-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Apr 2021 11:03:58 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13KB2xcZ136786; Tue, 20 Apr 2021 11:03:57 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 3809esejdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Apr 2021 11:03:57 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13KB3uTl016024; Tue, 20 Apr 2021 11:03:56 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Apr 2021 11:03:55 +0000 Date: Tue, 20 Apr 2021 14:03:48 +0300 From: Dan Carpenter To: Saurav Girepunje Cc: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com, hello@bryanbrattlof.com, hdegoede@redhat.com, saurav.girepunje@google.com, john.oldman@polehill.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: rtl8723bs: os_dep: remove multiple return Message-ID: <20210420110348.GC1981@kadam> References: <20210418173233.GA59153@user> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210418173233.GA59153@user> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: CeLZ5r5Xrtp8QxoMCXPX-79OtMGQyNj4 X-Proofpoint-GUID: CeLZ5r5Xrtp8QxoMCXPX-79OtMGQyNj4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 18, 2021 at 11:02:33PM +0530, Saurav Girepunje wrote: > on sdio_intf.c rtw_sdio_suspend call we have multiple > return which can replace by goto exit. As in all the places > return value is 0. > Why? Do nothing gotos just make the code harder to read and introduce forgot to set the error code bugs. regards, dan carpenter