Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3256287pxb; Tue, 20 Apr 2021 04:23:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsL4zKsGgjlwfVfTX3JYlJ3Sbb5tiduR9cmfLNdgXubeDgdLcCxh5WODYv4Z8SNIMX/wDT X-Received: by 2002:a17:906:d8cb:: with SMTP id re11mr26384259ejb.204.1618917783884; Tue, 20 Apr 2021 04:23:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618917783; cv=none; d=google.com; s=arc-20160816; b=vhpiTEemD9N8Z0I9wekiFHYbUO0UqsbkYq0035/JTe3ZChRnuGOOfaofpLB+5k3Q92 Z/T6XwMeAlLcIX/4Lj3WC3J1pXf33zNr2kwMOYsPD5FpckxRaz1e92Bm1TXfpLYNehGm jKUcWXoVJEOzIJd2VwivGnHLbifmZjr9IiWEApHFfWcElHrNTAOOYSdH3CB+zGrFcRKZ ZfEyJXg1B/eEffM3I9nJVzPeKDSBJ3hhq3aZs5OcEE/fBlhbiFdyOLnoo98jCUYl22VR 2qVj6tGaboM1UCEqaxdHcLdekV5FwYC0YYxySwtG7Nd8yFKzb0GeFk2QOgGDz/7panAT 2dww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tfZJcsESVJJ7LF8DyaFqXDwDLdv4yW2KMDeBAC866jo=; b=N6psxNuwTcpsebQPDK2/sCs/RCocWROYkOd+HHtmKR0xhm5L+wTkQ7F/l2ynq2aa+e Oi+6xc6BpYzcI0airHCacJcnn+In6CCeM9aruf0OE1bXlSnE4AiKYwK++RHwd+UwLAao uN4GiQhqPJ0BqCUpVRnY4YRNbBpy5atCaR5D7Pp3O4FVpxi2AAtEp4f4chiMVTjW8ZAr OMbBEPDA5SNxVzHsdR5Rtdlw1b0EkQmqp16M2d68IC3FZrky8fp9Oigfq6HC+rCtl/6m 2BFS8/yBsaPf7jShdB3iHwU0wC9dKSJv+gwEcCI72mWUhqtJXcUhf947uDJZ50z2vymV 9ZhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HHlhkFuI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si14904204edr.450.2021.04.20.04.22.40; Tue, 20 Apr 2021 04:23:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HHlhkFuI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232031AbhDTLVW (ORCPT + 99 others); Tue, 20 Apr 2021 07:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbhDTLVJ (ORCPT ); Tue, 20 Apr 2021 07:21:09 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6384AC06138A; Tue, 20 Apr 2021 04:20:38 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id cu16so17659565pjb.4; Tue, 20 Apr 2021 04:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=tfZJcsESVJJ7LF8DyaFqXDwDLdv4yW2KMDeBAC866jo=; b=HHlhkFuIT3/E5oLlfNfJToXUKA4q4QJqlBFVsRIiZB+9wu5yf2mtd+cQ/IPhUC22ON odRSdjzuYwQjrh6m9ZSyUKdRr6Eg31izfhHUVkrwbvtr/r43FPoTmJB0oiCInUDskMaP WOLKw2nfh71WRLarYH4+M5u+mzOgD3wU32KSsmo2ftT6AQVuDK6UcYptgWeyAswgxwGz bAvGB0raoTbqwAyj21X87L0gpAzG5U5KM5eFU4OYho8Z2qsiFTdtaOEvJWTTa9mJnLCN JFlqgsZbfSDdhITrYTNrHTZHvZ7WRRr43z/l3E8yvuuxhL/tKNstgnNBVYR0vxlokEp2 duYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=tfZJcsESVJJ7LF8DyaFqXDwDLdv4yW2KMDeBAC866jo=; b=CT8WBZxind3Dor6hjjoDBcQWcw7cSyaFGizLENyOOeCur3OFFyvImkCNes3H9NwSCj VN8SKIw1jDCwDR6Pc04ieBnfeO5RR98Aow86/d5c8wliPvGA6ctyre/t95cQrnwVPJJn XCc4mEgPjabHYFSJnW5PHvMf9J3JxRCrq8OmAdgvX23YKJLNez14Mm2jDauBOMV4FtfY XjtTSYY5Cm/NDYjkHW9QdeCHeHDJ3BhajWnxJk5zMMSPl/TX9IAhrRIPQg3umZrCYqE/ y8uK3PNgaplxdlVpD6bpYlPG55C86KZaU+62gbrat8tlGR81o3oMDrsN1zC4myvOY+E/ RUxw== X-Gm-Message-State: AOAM533SfrfZGsv0oQES3R/OkVl9i7b5bc/5TEaSgXsEv+On+NGmQ9rd GRxHvbuXgUktF561CLErIOc= X-Received: by 2002:a17:90a:6f45:: with SMTP id d63mr4459617pjk.39.1618917638072; Tue, 20 Apr 2021 04:20:38 -0700 (PDT) Received: from VM-0-3-centos.localdomain ([101.32.213.191]) by smtp.gmail.com with ESMTPSA id s40sm14187367pfw.100.2021.04.20.04.20.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Apr 2021 04:20:37 -0700 (PDT) From: brookxu To: paolo.valente@linaro.org, axboe@kernel.dk, tj@kernel.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/8] bfq: reset entity->prio_changed in bfq_init_entity() Date: Tue, 20 Apr 2021 19:20:24 +0800 Message-Id: <34c02f3525ed632ea1878591b41174aee50e953d.1618916839.git.brookxu@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunguang Xu Since weight, ioprio, ioprio_class will be updated in bfq_init_entity(), st->wsum will be updated in __bfq_activate_entity(), so when it is first active, it seems that __bfq_entity_update_weight_prio() has nothing to do. By resetting entity->prio_change in bfq_init_entity(), we can avoid unnecessary logic calls. Signed-off-by: Chunguang Xu --- block/bfq-cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c index c8c68dc..79a5aaa 100644 --- a/block/bfq-cgroup.c +++ b/block/bfq-cgroup.c @@ -426,6 +426,7 @@ void bfq_init_entity(struct bfq_entity *entity, struct bfq_group *bfqg) entity->weight = entity->new_weight; entity->orig_weight = entity->new_weight; + entity->prio_changed = 0; if (bfqq) { bfqq->ioprio = bfqq->new_ioprio; bfqq->ioprio_class = bfqq->new_ioprio_class; -- 1.8.3.1