Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5/6] staging: media: atomisp: fix CamelCase variable
 naming
To:     Fabio Aiuto <fabioaiuto83@gmail.com>,
        Deepak R Varma <mh12gx2825@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <cover.1618859059.git.drv@mailo.com>
 <17478627f128cdafed389b64ecf389d319295dd4.1618859059.git.drv@mailo.com>
 <20210420083902.GB1411@agape.jhs>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <7f678812-29d3-5f14-c8de-ea2d97861973@xs4all.nl>
Date:   Tue, 20 Apr 2021 15:26:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210420083902.GB1411@agape.jhs>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/04/2021 10:39, Fabio Aiuto wrote:
> Hi,
> 
> On Tue, Apr 20, 2021 at 12:45:57AM +0530, Deepak R Varma wrote:
>> Mixed case variable names are discouraged and they result in checkpatch
>> script "Avoid CamelCase" warnings. Replace such CamelCase variable names
>> by lower case strings according to the coding style guidelines.
>>
>> Signed-off-by: Deepak R Varma <drv@mailo.com>
>> ---
>>  .../media/atomisp/i2c/atomisp-mt9m114.c       | 62 +++++++++----------
>>  1 file changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> index 160bb58ce708..e63906a69e30 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
>> @@ -999,10 +999,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
>>  	struct mt9m114_device *dev = to_mt9m114_sensor(sd);
>>  	int ret = 0;
>>  	unsigned int coarse_integration = 0;
>> -	unsigned int FLines = 0;
>> -	unsigned int FrameLengthLines = 0; /* ExposureTime.FrameLengthLines; */
>> -	unsigned int AnalogGain, DigitalGain;
>> -	u32 AnalogGainToWrite = 0;
>> +	unsigned int f_lines = 0;
>> +	unsigned int frame_len_lines = 0; /* ExposureTime.FrameLengthLines; */
>> +	unsigned int analog_gain, digital_gain;
>> +	u32 analog_gain_to_write = 0;
>>
> 
> this patch is made of multiple logical changes, i.e. more than one
> variable at a time are renamed. Maybe this should be split in
> one patch per variable name.

I'm OK with this, it's pretty readable and obvious what is going on.

Regards,

	Hans