Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Shubhankar Kuranagatti <shubhankarvk@gmail.com>
CC:     Martin Petersen <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error
Thread-Topic: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error
Thread-Index: AQHXNeDAM9i24DGLBUSFRVEPonOnXKq9fJWA
Date:   Tue, 20 Apr 2021 14:48:05 +0000
Message-ID: <1A81A74B-DCA1-482C-8444-EAD143D432F7@oracle.com>
References: <20210420122846.gjh6pmzz2w37tqc5@kewl-virtual-machine>
In-Reply-To: <20210420122846.gjh6pmzz2w37tqc5@kewl-virtual-machine>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <957043EB1B554648862D99B90B1A11DA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cccc33f-c977-43ea-eb49-08d9040b4e62
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 14:48:05.5204
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z3QZRqMw2f3Yn9n3/7YRM67J2+9LUq/XPVMCjxIoU+iYRzdHn6PMYmLGD7mtSvBgGUMhUPUQtdLuHZCvItQER1BHbWqJ5UkJbroyWsTDLVg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4811
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9960 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 spamscore=0
 mlxscore=0 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000
 definitions=main-2104200111
X-Proofpoint-ORIG-GUID: AJf_ScCZLXMpWMai4lc5gPZAT5CiwOUW
X-Proofpoint-GUID: AJf_ScCZLXMpWMai4lc5gPZAT5CiwOUW
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 20, 2021, at 7:28 AM, Shubhankar Kuranagatti <shubhankarvk@gmail.c=
om> wrote:
>=20
> Tabs have been used to replace spaces.
> This is done to maintain code uniformity.
>=20
> Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
> ---
> drivers/target/target_core_pr.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core=
_pr.c
> index d4cc43afe05b..6538b2be1634 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -539,18 +539,18 @@ static int core_scsi3_pr_seq_non_holder(struct se_c=
md *cmd, u32 pr_reg_type,
> 			return 0;
> 		}
>        } else if (we && registered_nexus) {
> -               /*
> -                * Reads are allowed for Write Exclusive locks
> -                * from all registrants.
> -                */
> -               if (cmd->data_direction =3D=3D DMA_FROM_DEVICE) {
> -                       pr_debug("Allowing READ CDB: 0x%02x for %s"
> -                               " reservation\n", cdb[0],
> -                               core_scsi3_pr_dump_type(pr_reg_type));
> -
> -                       return 0;
> -               }
> -	}
> +		/*
> +		 * Reads are allowed for Write Exclusive locks
> +		 * from all registrants.
> +		 */
> +		if (cmd->data_direction =3D=3D DMA_FROM_DEVICE) {
> +			pr_debug("Allowing READ CDB: 0x%02x for %s"
> +					" reservation\n", cdb[0],
> +					core_scsi3_pr_dump_type(pr_reg_type));
> +
> +			return 0;
> +		}
> +		}

this last one has one too many tab.

> 	pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x"
> 		" for %s reservation\n", transport_dump_cmd_direction(cmd),
> 		(registered_nexus) ? "" : "un",
> --=20
> 2.17.1
>=20

--
Himanshu Madhani	 Oracle Linux Engineering