Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1618925829-90071-1-git-send-email-guoren@kernel.org>
In-Reply-To: <1618925829-90071-1-git-send-email-guoren@kernel.org>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Tue, 20 Apr 2021 23:20:37 +0800
Message-ID: <CAEbi=3fdKep_szy3jNYZrDr847avKYTHOQyNoUm5vy5ijv7Z0w@mail.gmail.com>
Subject: Re: [PATCH 1/3] nds32: Cleanup deprecated function strlen_user
To:     Guo Ren <guoren@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-riscv@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-csky@vger.kernel.org,
        linux-arch <linux-arch@vger.kernel.org>,
        Guo Ren <guoren@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

<guoren@kernel.org> =E6=96=BC 2021=E5=B9=B44=E6=9C=8820=E6=97=A5 =E9=80=B1=
=E4=BA=8C =E4=B8=8B=E5=8D=889:38=E5=AF=AB=E9=81=93=EF=BC=9A
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> $ grep strlen_user * -r
> arch/csky/include/asm/uaccess.h:#define strlen_user(str) strnlen_user(str=
, 32767)
> arch/csky/lib/usercopy.c: * strlen_user: - Get the size of a string in us=
er space.
> arch/ia64/lib/strlen.S: // Please note that in the case of strlen() as op=
posed to strlen_user()
> arch/mips/lib/strnlen_user.S: *  make strlen_user and strnlen_user access=
 the first few KSEG0
> arch/nds32/include/asm/uaccess.h:extern __must_check long strlen_user(con=
st char __user * str);
> arch/nios2/include/asm/uaccess.h:extern __must_check long strlen_user(con=
st char __user *str);
> arch/riscv/include/asm/uaccess.h:extern long __must_check strlen_user(con=
st char __user *str);
> kernel/trace/trace_probe_tmpl.h:static nokprobe_inline int fetch_store_st=
rlen_user(unsigned long addr);
> kernel/trace/trace_probe_tmpl.h:                        ret +=3D fetch_st=
ore_strlen_user(val + code->offset);
> kernel/trace/trace_uprobe.c:fetch_store_strlen_user(unsigned long addr)
> kernel/trace/trace_kprobe.c:fetch_store_strlen_user(unsigned long addr)
> kernel/trace/trace_kprobe.c:            return fetch_store_strlen_user(ad=
dr);
>
> See grep result, nobody uses it.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/nds32/include/asm/uaccess.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/nds32/include/asm/uaccess.h b/arch/nds32/include/asm/ua=
ccess.h
> index 010ba5f..d4cbf06 100644
> --- a/arch/nds32/include/asm/uaccess.h
> +++ b/arch/nds32/include/asm/uaccess.h
> @@ -260,7 +260,6 @@ do {                                                 =
                       \
>
>  extern unsigned long __arch_clear_user(void __user * addr, unsigned long=
 n);
>  extern long strncpy_from_user(char *dest, const char __user * src, long =
count);
> -extern __must_check long strlen_user(const char __user * str);
>  extern __must_check long strnlen_user(const char __user * str, long n);
>  extern unsigned long __arch_copy_from_user(void *to, const void __user *=
 from,
>                                             unsigned long n);

Thank you, Guo.
Acked-by: Greentime Hu <green.hu@gmail.com>