Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210416194709.155497-1-egranata@google.com> <20210420070129.GA3534874@infradead.org>
 <20210420060807-mutt-send-email-mst@kernel.org>
In-Reply-To: <20210420060807-mutt-send-email-mst@kernel.org>
From:   Enrico Granata <egranata@google.com>
Date:   Tue, 20 Apr 2021 10:28:13 -0600
Message-ID: <CAPR809tz_2yVvvYUhx629wFJA-+Z67Xx7ZAxNkcwRQbXMm8zvQ@mail.gmail.com>
Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Christoph Hellwig <hch@infradead.org>, jasowang@redhat.com,
        pbonzini@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
        axboe@kernel.dk, virtualization@lists.linux-foundation.org,
        linux-block@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I prepared a proposed patch to address these concerns:
https://lists.oasis-open.org/archives/virtio-dev/202104/msg00007.html

Feedback will be much appreciated

Thanks,
- Enrico

On Tue, Apr 20, 2021 at 4:08 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote:
> > Just to despit my 2 cents again:  I think the way this is specified
> > in the virtio spec is actively harmful and we should not suport it in
> > Linux.
> >
> > If others override me we at least need to require a detailed
> > documentation of these fields as the virto spec does not provide it.
> >
> > Please also do not add pointless over 80 character lines, and follow
> > the one value per sysfs file rule.
>
> Enrico would you like to raise the issues with the virtio TC
> for resolution?
>
> --
> MST
>