Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Jiri Olsa <jolsa@redhat.com>
CC:     Song Liu <song@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "acme@redhat.com" <acme@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "jolsa@kernel.org" <jolsa@kernel.org>
Subject: Re: [PATCH v4 3/4] perf-stat: introduce config
 stat.bpf-counter-events
Thread-Topic: [PATCH v4 3/4] perf-stat: introduce config
 stat.bpf-counter-events
Thread-Index: AQHXNVvKAeJiWUZbmU6OR6cKbig+tKq9qzkAgABAUQA=
Date:   Tue, 20 Apr 2021 21:21:32 +0000
Message-ID: <EE06CC67-3FFA-43E2-B032-EC8B37A9EC1C@fb.com>
References: <20210419203649.164121-1-song@kernel.org>
 <20210419203649.164121-4-song@kernel.org> <YH8P5ol5JRr5JO5v@krava>
In-Reply-To: <YH8P5ol5JRr5JO5v@krava>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C2708B3E81230845824AECBA4D3271CB@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e00a1748-b36b-45a2-6b0d-08d90442458e
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 21:21:32.9650
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BBHJL7kydtQLNzpVhFICesDpSOinsXkh9rFp2V6NnBn5giG/eplHpWYc+1T8I//d3iJ0TA63OsReIdMDy4vVbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1265
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: ukFXrP5U6NcAjaqvvtYuped57UoXB0Dq
X-Proofpoint-ORIG-GUID: ukFXrP5U6NcAjaqvvtYuped57UoXB0Dq
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-20_11:2021-04-20,2021-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 impostorscore=0
 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0
 mlxscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 bulkscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104200148
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 20, 2021, at 10:31 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>=20
> On Mon, Apr 19, 2021 at 01:36:48PM -0700, Song Liu wrote:
>=20
> SNIP
>=20
>> 	if (stat_config.initial_delay < 0) {
>> @@ -784,11 +790,11 @@ static int __run_perf_stat(int argc, const char **=
argv, int run_idx)
>> 	if (affinity__setup(&affinity) < 0)
>> 		return -1;
>>=20
>> -	if (target__has_bpf(&target)) {
>> -		evlist__for_each_entry(evsel_list, counter) {
>> -			if (bpf_counter__load(counter, &target))
>> -				return -1;
>> -		}
>> +	evlist__for_each_entry(evsel_list, counter) {
>> +		if (bpf_counter__load(counter, &target))
>> +			return -1;
>> +		if (!evsel__is_bpf(counter))
>> +			all_counters_use_bpf =3D false;
>=20
> could be done in bpf_counter__load, check below:
>=20
>> 	}
>>=20
>> 	evlist__for_each_cpu (evsel_list, i, cpu) {
>> diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter=
.c
>> index 5de991ab46af9..33b1888103dfa 100644
>> --- a/tools/perf/util/bpf_counter.c
>> +++ b/tools/perf/util/bpf_counter.c
>> @@ -790,7 +790,8 @@ int bpf_counter__load(struct evsel *evsel, struct ta=
rget *target)
>> {
>> 	if (target->bpf_str)
>> 		evsel->bpf_counter_ops =3D &bpf_program_profiler_ops;
>> -	else if (target->use_bpf)
>> +	else if (target->use_bpf ||
>> +		 evsel__match_bpf_counter_events(evsel->name))
>> 		evsel->bpf_counter_ops =3D &bperf_ops;
>=20
> with:
> 	else
> 		all_counters_use_bpf =3D false;
>=20
> I was also thinking of oving it to evlist, but it's sat specific,
> so I think it's good as static.. thanks for changing the implementation

Hmm... then we need to somehow make all_counters_use_bpf visible in
bpf_counter.c, which won't be very clean. Also, since this is stat=20
specific, I guess it is better to keep it inside builtin-stat.c?
The runtime overhead should be minimal.=20

Thanks,
Song