Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp179515pxy; Tue, 20 Apr 2021 16:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5Jk8Sf/hjaABeYZpA3znWBBzZbeW/lYWAsHt4/M6JuEsDrrGIDkdjRQoAClFh0BSddOu9 X-Received: by 2002:aa7:dac5:: with SMTP id x5mr34632066eds.286.1618959620844; Tue, 20 Apr 2021 16:00:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618959620; cv=none; d=google.com; s=arc-20160816; b=wB5wuXiocb6obGbyxIcJOiaqSa8f0wmEYunAlpvbQGEpDq5cRSuExXw+iNplfOIvPN ahk1YEb0ACSsw2cF5XFuwzlPiPXcnuC5yEf4x8f6BETTMiMH3Ck1iM43mLy5XW4+kEi6 /4hkpp1PGbjRrleEGJsQ+lpn0OMomifEp3Cgq9D764YWm4OzRG/y/vOWbQiU6jugvk2J VcvubZuHetlQ4WYEMhROZimSHQjYQPu+sqYW5YVDdpXMSe+iGVbbg7mdC5y7XgXKFh9S ieb2gsYA0iLKfx4wwAPXA8t/0sz7BY9zPeROhK01ss8YkmUSVBDE3DRISR169AdxlvK5 bYhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=RkDuC1Dr9J18+9eBYWIaxeIrmVv0oQ39iP9/w0aGwI0=; b=o7bsPXKW9p9S7J5rnQF6CcBH350ZTAPP7wNlMOCzY6ZexN/HUXpm5K+46YplRefi7J kaJTz7MT1kjbwfXuSoeYmPm+fAr8UEhRqnnmJ5Ptwel05jPvmsEuC0IlfBfvk98htfjW EV86qKOvTnSFTtNnMpTaYdxVhUTQ/bTccnRhS56l8QVVPHawbRfGNg3bKztY+OGuexgi 5COLGTWsEU20UMSqZhieCwNN+rbj/M8jYLF2oGU1e6RZsQhQQwHsLaM+4lYvbeYd0MD+ /K1awSIdRLhJTMTRuQEBZiXqnMp4DjY8gtG4RBWNHmF1wTGP0S6t63IUSa3avFjVGv2K HxJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rSTUaJOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz20si178432ejc.706.2021.04.20.15.59.44; Tue, 20 Apr 2021 16:00:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rSTUaJOq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234357AbhDTW6l (ORCPT + 99 others); Tue, 20 Apr 2021 18:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233992AbhDTW6j (ORCPT ); Tue, 20 Apr 2021 18:58:39 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18931C06174A; Tue, 20 Apr 2021 15:58:06 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id k73so38671052ybf.3; Tue, 20 Apr 2021 15:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RkDuC1Dr9J18+9eBYWIaxeIrmVv0oQ39iP9/w0aGwI0=; b=rSTUaJOqTKQ0k3Xy2fzNitQEnGvrkz6SKoqc+Dj1La3K+ghbFAGgLGJpfltyKFP1Jk Oy/u++v11zOtugul3vOguGBl+G4TGp4M/Ybatq/Se+E4x+8MNYhDzaOcrwD1eaalzc1c N6Qj5oOTw5O8UAoGUv4ApJmNyB+nBRmeky2joYtneRxCo3iNVhWIEWH2Op+TDiTi8ks6 3fSWfRRpWyeTmRoIzsAi0oa2g5/iaVm8YkrzACOgTBaKoqeuJ083SKN/+lfvQZLN80Ey geNOcKRzcX/77A8Qd8oEdPk4wwYNcVR3/yDbC463iB2lURfSdeatNlh7aQXvjtb7EfGv efEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RkDuC1Dr9J18+9eBYWIaxeIrmVv0oQ39iP9/w0aGwI0=; b=si+HsPMzIzhViBkIYxOMzdWn+DgT0XvMzQ2S8AMORF+kVd+wgHO7RDTHCFylDWoAUr gH7ZQbwNJYJ90Y77h2TypiZMgb5DTkdBDIeDdW+sOBYAa18KQfKo/n2WwKRSoPG6M+8U e9o92v8/oF5qVX3/l79fheKKYywUb7J9jTY9Oqe9lCu9g2WiV/Ch7mLv7W0LrUTDMhff 1Cwj0zsJZKerqgCUozqBskRBMxtQ5En8T+c74n+HeoMsvvDyZ1zBZ4CRl0EAXh/fqdwH glRBvYuX4AabaptsnnltHXokf+bHpP4zJ0TGZx3ixtgVZGUkojCzm+OaBpwUxm8TpSCf bhJQ== X-Gm-Message-State: AOAM531vmIF9WtS/8KSCXWx7dWv9YwLh+zTcEtWaXG3ydr72O5/F79uz qfSCHV3pKpcipgvHFEdxvslh6xAFbR1oRzcamccLipQRaQM= X-Received: by 2002:a25:ba06:: with SMTP id t6mr19867701ybg.459.1618959485359; Tue, 20 Apr 2021 15:58:05 -0700 (PDT) MIME-Version: 1.0 References: <20210420154140.80034-1-kuniyu@amazon.co.jp> <20210420154140.80034-12-kuniyu@amazon.co.jp> In-Reply-To: <20210420154140.80034-12-kuniyu@amazon.co.jp> From: Andrii Nakryiko Date: Tue, 20 Apr 2021 15:57:54 -0700 Message-ID: Subject: Re: [PATCH v3 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE. To: Kuniyuki Iwashima Cc: "David S . Miller" , Jakub Kicinski , Eric Dumazet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Benjamin Herrenschmidt , Kuniyuki Iwashima , bpf , Networking , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2021 at 8:45 AM Kuniyuki Iwashima wrote: > > This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE and > removes 'static' from settimeo() in network_helpers.c. > > Signed-off-by: Kuniyuki Iwashima > --- Almost everything in prog_tests/migrate_reuseport.c should be static, functions and variables. Except the test_migrate_reuseport, of course. But thank you for using ASSERT_xxx()! :) > tools/testing/selftests/bpf/network_helpers.c | 2 +- > tools/testing/selftests/bpf/network_helpers.h | 1 + > .../bpf/prog_tests/migrate_reuseport.c | 483 ++++++++++++++++++ > .../bpf/progs/test_migrate_reuseport.c | 51 ++ > 4 files changed, 536 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c > create mode 100644 tools/testing/selftests/bpf/progs/test_migrate_reuseport.c > [...]