Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: a100u2w: remove useless variable
To:     Julian Calaby <julian.calaby@gmail.com>
References: <1618197759-128087-1-git-send-email-jiapeng.chong@linux.alibaba.com>
 <CAGRGNgVucQWcGiUnWtsC=oRDXrWkQ13CFojOcM7xU+4TukUoOA@mail.gmail.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From:   =?UTF-8?B?56eN5ZiJ6bmP?= <jiapeng.chong@linux.alibaba.com>
Message-ID: <aebf4084-9e41-1e8b-35ca-ae57f934fca5@linux.alibaba.com>
Date:   Wed, 21 Apr 2021 10:16:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <CAGRGNgVucQWcGiUnWtsC=oRDXrWkQ13CFojOcM7xU+4TukUoOA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2021/4/17 14:34, Julian Calaby wrote:
> Hi Jiapeng,
> 
> On Mon, Apr 12, 2021 at 1:23 PM Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com> wrote:
>>
>> Fix the following gcc warning:
>>
>> drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not
>> used [-Wunused-but-set-variable].
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>>   drivers/scsi/a100u2w.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
>> index 66c5143..855a3fe 100644
>> --- a/drivers/scsi/a100u2w.c
>> +++ b/drivers/scsi/a100u2w.c
>> @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
>>          int error = -ENODEV;
>>          u32 sz;
>>          unsigned long biosaddr;
>> -       char *bios_phys;
>>
>>          if (pci_enable_device(pdev))
>>                  goto out;
>> @@ -1141,7 +1140,7 @@ static int inia100_probe_one(struct pci_dev *pdev,
>>
>>          biosaddr = host->BIOScfg;
>>          biosaddr = (biosaddr << 4);
>> -       bios_phys = phys_to_virt(biosaddr);
>> +       phys_to_virt(biosaddr);
> 
> Does phys_to_virt() have side effects? If it doesn't, there's a lot
> more stuff that can get deleted here.
> 
> Thanks,
> 
OK, I'll delete phys_to_virt() and send V2.