Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 04:10:19 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Yejune Deng <yejune.deng@gmail.com>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab.c: use 'ac' from the caller
Message-ID: <20210421031019.GF3596236@casper.infradead.org>
References: <20210421022518.67451-1-yejune.deng@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210421022518.67451-1-yejune.deng@gmail.com>
Precedence: bulk

On Wed, Apr 21, 2021 at 10:25:17AM +0800, Yejune Deng wrote:
> @@ -3045,12 +3044,7 @@ static inline void *____cache_alloc(struct kmem_cache *cachep, gfp_t flags)
>  	}
>  
>  	STATS_INC_ALLOCMISS(cachep);
> -	objp = cache_alloc_refill(cachep, flags);
> -	/*
> -	 * the 'ac' may be updated by cache_alloc_refill(),
> -	 * and kmemleak_erase() requires its correct value.
> -	 */
> -	ac = cpu_cache_get(cachep);
> +	objp = cache_alloc_refill(cachep, ac, flags);

I think passing 'ac' in is fine (probably?  I don't know this code
deeply), but deleting this call to 'ac' is clearly wrong.  The comment
even tells you that!  I just verified the code, and the comment is
correct.