Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp218196pxy; Wed, 21 Apr 2021 01:01:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvLDuV87lxw752A37eyWeUmnKcmfTHVHSUfh0jb/WazzQMe5HuVW0R+drIe6qXPngIxt/J X-Received: by 2002:a63:d507:: with SMTP id c7mr20623579pgg.306.1618992113952; Wed, 21 Apr 2021 01:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618992113; cv=none; d=google.com; s=arc-20160816; b=FylVvvNB9KXGPASD5isMdv1dRgvod+ilkMB+CfLVUDWZN0tZUPD3wtpQhN7VRF985D Q3x5cV8swktpPOCV5w74ArdeAJMUdPROkFOQpta4fsDWGwWZre0BJBWguP6vRaH6rUrK NzllUmGPdU9LO3LsFcCf8dxPSQ5Kk5ITe4rGJTgzykeHi31ncekkhITgiCkB/I/D7yqK kBTZNq9xuIdx3H0g09BOInIP7hvfxR/dz3rXekdcX9As5IrZIFJQ34lcvrrlN0Av0NbV 1XtHj6sY9cOYObhotOuMFXdQ9M986B5jY8r4TTnHkIY50bGHPmOhYDNod6kcpkH9cEmU nh+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=PFjJiDn1uzUtuBvXrUJVpNv66qIwKuOdVb9Goe+LBS0=; b=qz6Vov6Qp+TDxjxeRuwjNKEP9QgCIingxJ6d3e0zXZslwxr/2K1eqPnJ39YOQJ9lbZ 0J5lkbjAegF9aZZJw4jic7y8amU5dQNR+I1+mM2HOqbUs/Rk/RqD7it39KLvLerYlbfB vD3bQe9H5BCXD6+i7m6Sqj0FU3zX2Y9/sakU0+yXlIxgmbwr3ngGl7Yn4w/E0niYy1Uv AuTDvILeLV7QSd+DJypDWY7VZ5RFL6Rkbth/Gh6FWKk4w1JUEPd5qVmhd4Ve+gmrGkO4 HMWqUi2oqeL4rk+3G5k78FjI/Q86X+cMKyUakwRBdiNx5zf+8W99bUC9VgwzlVvWqzDG 0p2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si1501473pfp.229.2021.04.21.01.01.41; Wed, 21 Apr 2021 01:01:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237133AbhDUHpc (ORCPT + 99 others); Wed, 21 Apr 2021 03:45:32 -0400 Received: from mga18.intel.com ([134.134.136.126]:35638 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235209AbhDUHpb (ORCPT ); Wed, 21 Apr 2021 03:45:31 -0400 IronPort-SDR: oQEw/3uJ4MFqYNYHwJfHF/7xo/bAml2UwtF4i63Imjh4BYjsTgAOEf+kmk8Pb95wjPCfy1T1V9 Pq3FNpD9gIEw== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="183145104" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="183145104" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 00:44:58 -0700 IronPort-SDR: /ZfMj8tehuOV2jaCj9TI57dzsFt0fcxC7/DYzUco5ddScdT7bOEChibRekFkuP5opoRN7g8iL4 mGOXkNzA+4Rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="617260348" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by fmsmga005.fm.intel.com with ESMTP; 21 Apr 2021 00:44:56 -0700 Subject: Re: [PATCH resend] xhci: Do not use GFP_KERNEL in (potentially) atomic context To: Christophe JAILLET , mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Mathias Nyman Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: <5eb0bea7-46b6-7225-7603-cac3195a92e4@linux.intel.com> Date: Wed, 21 Apr 2021 10:46:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.4.2021 15.32, Christophe JAILLET wrote: > 'xhci_urb_enqueue()' is passed a 'mem_flags' argument, because "URBs may be > submitted in interrupt context" (see comment related to 'usb_submit_urb()' > in 'drivers/usb/core/urb.c') > > So this flag should be used in all the calling chain. > Up to now, 'xhci_check_maxpacket()' which is only called from > 'xhci_urb_enqueue()', uses GFP_KERNEL. > > Be safe and pass the mem_flags to this function as well. > > Fixes: ddba5cd0aeff ("xhci: Use command structures when queuing commands on the command ring") > Signed-off-by: Christophe JAILLET > --- > I'm not 100% sure of the Fixes tag. The commit is the only that introduced > this GFP_KERNEL, but I've not checked what was the behavior before that. > > If the patch is correct, I guess that a cc stable should be welcome. > > This patch was proposed on 14/08/20. It has been rebased on latest -next tree. Added to queue, and added stable tag Thanks -Mathias