Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp248563pxy; Wed, 21 Apr 2021 01:57:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj3uOrPnbEt6ypXax+yDy+cScoPo6g2aklnM5QZ1ooBlJfa6Cggj589Tfc9TnuS5QUhD9L X-Received: by 2002:a63:eb12:: with SMTP id t18mr21254403pgh.349.1618995444286; Wed, 21 Apr 2021 01:57:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618995444; cv=none; d=google.com; s=arc-20160816; b=dZvstqc3t1N+xNEqMgCCaorLPihJURjrbCup2R9kk0gfHiIeC0oPezf7a0eb3Ff/BN 5+/gEULnnGCju+USWaRv3LJZ72qEAgIyHVdzwEu1qSck2Q3LUvoZozsGFkKoLyprgGRI Ff7O4T91W2tDxNsnnhLy9hFDTGnghOvmLS0N2FPuAhSSrdIM14YyD0OJRVtNkPdrasxO ecWfQLrlvU9Q3LuPFVa28GmGD0W6xlclOhJPKRd21wk4Z3OQAOIptfkusX2egf2AozFq RxhzgIr2REzbfRarcyOCgE8QrQyLA/ktaSgObVWSeEI8EV2Kt2P1r7nRGmeP7vvatg1R rySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oNcGkR2RFmcYTTYOpVq8cFHchJCu8Yp9TBtAmFiyPW4=; b=XQkQpiEeXtWn6LXCY9Ukz3I0lJ04zt6/3c6WYJO1flyQXH90xmNQBOOezkXLrH3yZl wK6qvAxklK7bvCWDzUnURIFrTJWqjkElVBf10j4L0YwBmv5tkjNw0DGGik+ZbXcV5mC7 3WNZCy6XBLegLK8XcyLtVQgFc44I3u9gMbVdgMCsFP7WdiI9116sWHvoiS+ySF3a+Tcb OH99r6Ax74cbe5SXrYfZVAlZKaBXCQWyTuZphQEcEU9I8a/loqOoVcL9kguzvFDRId5O khqKWLsS4AgH8HNCJvHuJ3YhjQlovzwWTw2gxKR/wEnmSy65AID24hGoOblKQL0rlwC4 +Bnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y1si1814722plb.251.2021.04.21.01.57.12; Wed, 21 Apr 2021 01:57:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236721AbhDUIkj (ORCPT + 99 others); Wed, 21 Apr 2021 04:40:39 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16609 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbhDUIki (ORCPT ); Wed, 21 Apr 2021 04:40:38 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FQDT04nV0z17RLn; Wed, 21 Apr 2021 16:37:40 +0800 (CST) Received: from szvp000203569.huawei.com (10.120.216.130) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Wed, 21 Apr 2021 16:39:52 +0800 From: Chao Yu To: CC: , , , Chao Yu Subject: [PATCH] f2fs: compress: remove unneed check condition Date: Wed, 21 Apr 2021 16:39:41 +0800 Message-ID: <20210421083941.66371-1-yuchao0@huawei.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In only call path of __cluster_may_compress(), __f2fs_write_data_pages() has checked SBI_POR_DOING condition, and also cluster_may_compress() has checked CP_ERROR_FLAG condition, so remove redundant check condition in __cluster_may_compress() for cleanup. Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index 3c9d797dbdd6..532c311e3a89 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -906,11 +906,6 @@ static bool __cluster_may_compress(struct compress_ctx *cc) f2fs_bug_on(sbi, !page); - if (unlikely(f2fs_cp_error(sbi))) - return false; - if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) - return false; - /* beyond EOF */ if (page->index >= nr_pages) return false; -- 2.29.2