Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751077AbWJRIeg (ORCPT ); Wed, 18 Oct 2006 04:34:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751053AbWJRIef (ORCPT ); Wed, 18 Oct 2006 04:34:35 -0400 Received: from smtp.osdl.org ([65.172.181.4]:52121 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750866AbWJRIee (ORCPT ); Wed, 18 Oct 2006 04:34:34 -0400 Date: Wed, 18 Oct 2006 01:31:03 -0700 From: Andrew Morton To: Josef Sipek Cc: linux-kernel@vger.kernel.org, hch@infradead.org, viro@ftp.linux.org.uk, mhalcrow@us.ibm.com, penberg@cs.helsinki.fi, linux-fsdevel@vger.kernel.org Subject: Re: fsstack: struct path Message-Id: <20061018013103.4ad6311a.akpm@osdl.org> In-Reply-To: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> References: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 29 On Wed, 18 Oct 2006 00:23:23 -0400 Josef Sipek wrote: > Few weeks ago, I noticed that fs/namei.c defines struct path: > > struct path { > struct vfsmount *mnt; > struct dentry *dentry; > }; > > I think it would make sense to move it into include/linux/ as it is quite > useful (and it would discourage the (ab)use of struct nameidata.) > > The fsstack code could benefit from it as the stackable fs dentries have to > keep track of the lower dentry as well as the lower vfsmount. > > One, rather unfortunate, fact is that struct path is also defined in > include/linux/reiserfs_fs.h as something completely different - reiserfs > specific. > > Any thoughts? > reiserfs is being bad. s/path/reiserfs_path/g - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/