Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 11:38:33 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Kevin Tang <kevin3.tang@gmail.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi
 controller bindings
Message-ID: <20210421093833.dhnkf2265hrtwkzr@gilmour>
References: <20210222132822.7830-1-kevin3.tang@gmail.com>
 <20210222132822.7830-6-kevin3.tang@gmail.com>
 <20210324111316.ggo5deacaoecu27q@gilmour>
 <CAFPSGXah3gKKHXhukRAPT=RjQZTnvDznG+619+8tah-hfFrUzA@mail.gmail.com>
 <20210407104653.l4xwfl3qshaimat3@gilmour>
 <CAFPSGXaQKeKMKC7MGXhxQErB_yh_eE8khk1hOrjHnuOH20Gg4Q@mail.gmail.com>
 <20210415084230.moqxuy3caym3kupk@gilmour>
 <CAFPSGXYujpe=C64f=MJAUmqGwoP6t=NE+nNqezmKUTcyrxt+=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rpyo6ffe5bipimwd"
Content-Disposition: inline
In-Reply-To: <CAFPSGXYujpe=C64f=MJAUmqGwoP6t=NE+nNqezmKUTcyrxt+=g@mail.gmail.com>
Precedence: bulk


--rpyo6ffe5bipimwd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Apr 19, 2021 at 12:33:42AM +0800, Kevin Tang wrote:
> Maxime Ripard <maxime@cerno.tech> =E4=BA=8E2021=E5=B9=B44=E6=9C=8815=E6=
=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=884:42=E5=86=99=E9=81=93=EF=BC=9A
> >
> > On Fri, Apr 09, 2021 at 08:23:19AM +0800, Kevin Tang wrote:
> > > Maxime Ripard <maxime@cerno.tech> =E4=BA=8E2021=E5=B9=B44=E6=9C=887=
=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=886:46=E5=86=99=E9=81=93=EF=BC=
=9A
> > >
> > > > On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote:
> > > > > Hi Maxime,
> > > > >
> > > > > Maxime Ripard <maxime@cerno.tech> =E4=BA=8E2021=E5=B9=B43=E6=9C=
=8824=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=887:13=E5=86=99=E9=81=93=
=EF=BC=9A
> > > > >
> > > > > > On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote:
> > > > > > > From: Kevin Tang <kevin.tang@unisoc.com>
> > > > > > >
> > > > > > > Adds MIPI DSI Controller
> > > > > > > support for Unisoc's display subsystem.
> > > > > > >
> > > > > > > Cc: Orson Zhai <orsonzhai@gmail.com>
> > > > > > > Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> > > > > > > Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > ---
> > > > > > >  .../display/sprd/sprd,sharkl3-dsi-host.yaml   | 102
> > > > ++++++++++++++++++
> > > > > > >  1 file changed, 102 insertions(+)
> > > > > > >  create mode 100644
> > > > > >
> > > > Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-hos=
t.yaml
> > > > > > >
> > > > > > > diff --git
> > > > > >
> > > > a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-h=
ost.yaml
> > > > > >
> > > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-h=
ost.yaml
> > > > > > > new file mode 100644
> > > > > > > index 000000000..d439f688f
> > > > > > > --- /dev/null
> > > > > > > +++
> > > > > >
> > > > b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-h=
ost.yaml
> > > > > > > @@ -0,0 +1,102 @@
> > > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > > > > +%YAML 1.2
> > > > > > > +---
> > > > > > > +$id:
> > > > > > http://devicetree.org/schemas/display/sprd/sprd,sharkl3-dsi-hos=
t.yaml#
> > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > > > +
> > > > > > > +title: Unisoc MIPI DSI Controller
> > > > > > > +
> > > > > > > +maintainers:
> > > > > > > +  - Kevin Tang <kevin.tang@unisoc.com>
> > > > > > > +
> > > > > > > +properties:
> > > > > > > +  compatible:
> > > > > > > +    const: sprd,sharkl3-dsi-host
> > > > > > > +
> > > > > > > +  reg:
> > > > > > > +    maxItems: 1
> > > > > > > +
> > > > > > > +  interrupts:
> > > > > > > +    maxItems: 2
> > > > > > > +
> > > > > > > +  clocks:
> > > > > > > +    minItems: 1
> > > > > > > +
> > > > > > > +  clock-names:
> > > > > > > +    items:
> > > > > > > +      - const: clk_src_96m
> > > > > > > +
> > > > > > > +  power-domains:
> > > > > > > +    maxItems: 1
> > > > > > > +
> > > > > > > +  ports:
> > > > > > > +    type: object
> > > > > > > +
> > > > > > > +    properties:
> > > > > > > +      "#address-cells":
> > > > > > > +        const: 1
> > > > > > > +
> > > > > > > +      "#size-cells":
> > > > > > > +        const: 0
> > > > > > > +
> > > > > > > +      port@0:
> > > > > > > +        type: object
> > > > > > > +        description:
> > > > > > > +          A port node with endpoint definitions as defined in
> > > > > > > +
> > > > Documentation/devicetree/bindings/media/video-interfaces.txt.
> > > > > > > +          That port should be the input endpoint, usually co=
ming
> > > > from
> > > > > > > +          the associated DPU.
> > > > > > > +      port@1:
> > > > > > > +        type: object
> > > > > > > +        description:
> > > > > > > +          A port node with endpoint definitions as defined in
> > > > > > > +
> > > > Documentation/devicetree/bindings/media/video-interfaces.txt.
> > > > > > > +          That port should be the output endpoint, usually o=
utput to
> > > > > > > +          the associated panel.
> > > > > >
> > > > > > The DSI generic binding asks that peripherals that are controll=
ed
> > > > > > through a DCS be a subnode of the MIPI-DSI bus, not through a p=
ort
> > > > > > endpoint.
> > > > > >
> > > > >  Our DSI controller don't support DCS now...
> > > >
> > > > I'm not sure I follow you, you mentionned in the patch 4 that you w=
ere
> > > > testing for a device to be in command mode, how would that work wit=
hout
> > > > DCS support?
> > > >
> > > Sorry, I see DCS as DSC, pls ignore my previous comments.
> > >
> > > dsi input node is display controller and dsi output node is panel,
> > > I still don't understand what it has to do with dcs? and it seems that
> > > other vendors also like this.
> > >
> > > can you help provide some cases?
> >
> > So the device tree is a tree organized through which bus controls which
> > device: Your DSI controller is accessed through a memory-mapped region
> > and is thus a child node of the main bus (I guess?) and then, since the
> > DSI panel is going to be controlled through the DSI controller and
> > MIPI-DCS, it needs to be a child of the display controller.
> Yeah, access DSI controller registers is through AHB bus.
>=20
> I'm a little confused, DSI panel node should be a child of the display
> controller?

If they are controlled through DSI, yes.

> I found a lot of cases are organized like this, we also do like it.
> https://elixir.bootlin.com/linux/v5.11.15/source/arch/arm/boot/dts/tegra1=
14-dalmore.dts#L48
>=20
> >
> > This is exactly what is being described here:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree=
/Documentation/devicetree/bindings/display/mipi-dsi-bus.txt#n42
> >
> > The second port is thus not needed at all
> Yeah, dsi_out port is no need, should be detele.
> Besides, I also have a question, if out dsi-phy is separate driver(eg,
> dphy have it's own bus)
> dsi_out port should be "dphy_in"?

You could argue both, but phys are usually represented through the phys pro=
perty.

Maxime

--rpyo6ffe5bipimwd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYH/ymQAKCRDj7w1vZxhR
xT1aAQCFJmJwubW5uuEih1MMXtaGdOWmBlYyTp0PjzRuH48wVAD/YnauZ0hvub2Q
gTr8Pxphr82Txyym/aDFSxH2AeubEQs=
=9LY+
-----END PGP SIGNATURE-----

--rpyo6ffe5bipimwd--