Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 09:47:27 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Michael Kelley <mikelley@microsoft.com>
Cc:     Joseph Salisbury <Joseph.Salisbury@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drivers: hv: Create a consistent pattern for
 checking Hyper-V hypercall status
Message-ID: <20210421094727.ulbzt7uktpxfw4hg@liuwe-devbox-debian-v2>
References: <1618620183-9967-1-git-send-email-joseph.salisbury@linux.microsoft.com>
 <1618620183-9967-2-git-send-email-joseph.salisbury@linux.microsoft.com>
 <MWHPR21MB15936E55F2A6FD6994DC4F34D7489@MWHPR21MB1593.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR21MB15936E55F2A6FD6994DC4F34D7489@MWHPR21MB1593.namprd21.prod.outlook.com>
Precedence: bulk

On Tue, Apr 20, 2021 at 09:30:08PM +0000, Michael Kelley wrote:
> From: Joseph Salisbury <joseph.salisbury@linux.microsoft.com> Sent: Friday, April 16, 2021 5:43 PM
> > 
> > There is not a consistent pattern for checking Hyper-V hypercall status.
> > Existing code uses a number of variants.  The variants work, but a consistent
> > pattern would improve the readability of the code, and be more conformant
> > to what the Hyper-V TLFS says about hypercall status.
> > 
> > Implemented new helper functions hv_result(), hv_result_success(), and
> > hv_repcomp().  Changed the places where hv_do_hypercall() and related variants
> > are used to use the helper functions.
> > 
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@microsoft.com>
> > ---
> >  arch/x86/hyperv/hv_apic.c           | 16 +++++++++-------
> >  arch/x86/hyperv/hv_init.c           |  2 +-
> >  arch/x86/hyperv/hv_proc.c           | 25 ++++++++++---------------
> >  arch/x86/hyperv/irqdomain.c         |  6 +++---
> >  arch/x86/hyperv/mmu.c               |  8 ++++----
> >  arch/x86/hyperv/nested.c            |  8 ++++----
> >  arch/x86/include/asm/mshyperv.h     |  1 +
> >  drivers/hv/hv.c                     |  2 +-
> >  drivers/pci/controller/pci-hyperv.c |  2 +-
> >  include/asm-generic/mshyperv.h      | 25 ++++++++++++++++++++-----
> >  10 files changed, 54 insertions(+), 41 deletions(-)
> 
> Wei -- I have gone through these changes reasonably carefully, but
> your review of the Linux-in-the-root-partition changes would be a good
> double-check.  It's too easy to get the sense of the tests backwards. :-(

The code looks correct to me.

> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Thanks. I will apply this series to hyperv-next shortly.

Wei.