Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp413242pxy; Wed, 21 Apr 2021 06:10:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztRzv2e/qQeD3Y6ChjgSAtokUQkzmRMQBOiq00icruGMymNy7NqOKY2bft0bQBtwApxryq X-Received: by 2002:a17:906:3e54:: with SMTP id t20mr32791696eji.53.1619010610068; Wed, 21 Apr 2021 06:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619010610; cv=none; d=google.com; s=arc-20160816; b=XsXUDQfpHyhAVP5h24Q8Y45GuEPEAefyIVxprt3Dfi5ztJHvgwhurZ9cVqDMpdOYuw Dku9A5OIHZgmF+2DdSPtj11vjPffpZEgN428ll9a1t7LjjivY1pHZwyCl23QttEiqthB QX/i4aEShvgL72VqknzLk7ye/9SWxesPCzmL8671Qk6O+HrnnwnUkm5V3/bGAUQPed3z LAIrmQizJBii/zQbCA28LgptVPBEHAHqZsL9yU6KD9mZ7EPtPewnX7W49tnnjLHzuJRt Acs2TwVAT8hNqgKHI40pcbqCye+KMHv9Vwb9de3cxPxui4YF3mvBwYMjFrhW/AsoMkAU pteA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+IHyHihGFBULOdf3eNfII3t9XonTXx8ab2n4CHX2wBA=; b=PJrxDEtHtQoo3njtn3cN2YW93Hzjga+AJDvw/oSC2T440xYgf73vnYH+6n89AgdA4u ceoVJT5PAEW0m7gs8SCFxfreisXdBQ6pWl5FCaXtkTRMn0M+dgbR19FCB973COFczNAS Cp+pe/23uGLEk/09R/lOyPt8FQj7/fR79J80CMGbKKo6DSIQnLwHi348mm+m47y6YMyz cJa4IjTA+z4cwFLFhHM9AWxAasM58tO5nELHOK/No3t2/D9skqAImKro4jkaZ0xdavHI iYJVTRZO7v4Mj/7cLgOLYrhTo4eDIItSqhoq1sixVojLJ2oJ5XvlnwF20n0lJhqsurRx rycA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l6jo1LZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo13si1705373ejb.655.2021.04.21.06.09.46; Wed, 21 Apr 2021 06:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=l6jo1LZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240600AbhDUNEA (ORCPT + 99 others); Wed, 21 Apr 2021 09:04:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240539AbhDUNDp (ORCPT ); Wed, 21 Apr 2021 09:03:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50ECA6143C; Wed, 21 Apr 2021 13:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010192; bh=CKTU3ju0CTssqZVCVjEK831bAjS6bxbKLGwVEl+0GnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l6jo1LZfuKNdUOwOc5JY8xyG4Wr38F7UOdrs/HLIPnrKejMsxgwGqodNzoGOC5hlC HGLr/Bjpd+B7FY/qIIngKKbE/W4027Aa0WkPySW3QOIQwNgtmPIBnE8mdfUIVJJjZo /NiMVZGG0n4q19q3O5tirHPfkUxQslGe1VazIAYM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Qiushi Wu , "David S . Miller" Subject: [PATCH 046/190] Revert "net/mlx4_core: fix a memory leak bug." Date: Wed, 21 Apr 2021 14:58:41 +0200 Message-Id: <20210421130105.1226686-47-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit febfd9d3c7f74063e8e630b15413ca91b567f963. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Qiushi Wu Cc: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index f6cfec81ccc3..380e027ba5df 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work) if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - goto out; + return; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET); -- 2.31.1