Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp459382pxy; Wed, 21 Apr 2021 07:08:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6Sz6OL0h5IG+JtC27oZvdggjVOge2g8RKDrUdNvwUigDNBFsybIAn57HaAqUaHNwoKcof X-Received: by 2002:aa7:c7c5:: with SMTP id o5mr38441333eds.31.1619014128236; Wed, 21 Apr 2021 07:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619014128; cv=none; d=google.com; s=arc-20160816; b=Jyv0l8CUszr09Wsdxxs+gmPUtAznoQeV3a7baMyY91SwsnN95QsHxnh3+1N7q8py+m 8uhXXcxWFfAXdgMiTTvuTymTJZL9rw1myKlf8Mts1m1XvW7GdFy7s9MgPNWGJIz5A5FS MK3BVGq0nDg1ZCiajdOp0MSAnfIdKQAHkC/Bv3nfRFu0G/DmIJ4w/6NOj4FuJUWwRa3w klM19ZOUbuVVUmc1bXrI0gKi9S6QI3KGc//YuXbrJn/R2K5DxdC5bXd5ok9lscuug/6N wOa+9NtV5ULJ5wfZek9D7TaP4HS0JzLbgenXL18zKRph0fdc7aMyP/ENmWtua/vzg/fP BibQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=JiwbXjmwv7WSPaNysAbVhn2SptL19dKY+XRIVBMw2AM=; b=eOzjIDU7EFZYeWPZA5IKwF9YqnyLPjHTdH1Dp1j5T43QDby2hzPIafxuonkdo8X7gq Hi//H2amXAK6zO5uzmkuWfinmUoT7ekmmRQ0lknxmJvcQBe3B/Gw2uBtJX3dfrRH/teX 8iaiJrp7p0ctJkiCRZkwhav9lN+629vZXisbAV8g/8AH4/x+sEioy2E3H0hT6XlAdLh3 tuEnJMy65Zqs/APPEuArHvW9ITJc1G5sjfq3ew9jMEFCY3xBD0OoA9Ys4DN0RSn6xTWY Vn4WXq5QVHgGMWYmQrZWevXxTrzPgs/ucSZF7M9pjtHOav3zh7i9QY7CQe8sylJnnjKz 0c7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CRbJnXzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cw25si2096825edb.112.2021.04.21.07.08.24; Wed, 21 Apr 2021 07:08:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CRbJnXzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238837AbhDUM1E (ORCPT + 99 others); Wed, 21 Apr 2021 08:27:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37289 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238011AbhDUM1D (ORCPT ); Wed, 21 Apr 2021 08:27:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619007990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JiwbXjmwv7WSPaNysAbVhn2SptL19dKY+XRIVBMw2AM=; b=CRbJnXzNEuxsl9oJ/8fSufw7SkKE4Jd72SMGl5kUvy5PdhVz/1IqKLpMKovkkbn6NqNEXT BdYo+jyj3HizX/x270tA9SIaGH8zWR55t3hyH8TCy6zm97pjPqCMjOnVd5GNNpXS0p4fwK 1G4lJucOS0/Nmtjv+VLN26fYkmR7D98= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-k-zTHqAyPgS0hEBUZGqgpA-1; Wed, 21 Apr 2021 08:26:28 -0400 X-MC-Unique: k-zTHqAyPgS0hEBUZGqgpA-1 Received: by mail-ed1-f71.google.com with SMTP id n18-20020a0564020612b02903853320059eso5903726edv.0 for ; Wed, 21 Apr 2021 05:26:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JiwbXjmwv7WSPaNysAbVhn2SptL19dKY+XRIVBMw2AM=; b=MDmnYZ17mfDixhsf03u/UidBltZmbvqNg+95bQ8s+DVUIYNIm+yvq5GAW7W/CMcxT5 iV4/kbdYpvOHekpvhjALmCLdLorFtvmWjFXUStInAc0/xP9Tl9dMV0cI2PLyo6CnHSb0 p5hZuZnsR/PC8jaZqK+EkPhVvUMjD2SefRMKpO4qQt7O81c5XxDvxrQQs975/JL19uJT TAxhbTbG3MT+7RCU3h2KGgegYByXDTp2I7SPhbgtK8pV6+9n95LFc6wuhJjj45Hpp9qi Fa/Zqx6sSTZTUAzJwmmXhGvObsu9njXR4rrTFwDDZGItcTLoQllaIkgUJEsbk6knW4zT gUoQ== X-Gm-Message-State: AOAM532EvmvF1BDRxM14ACpI9FDr0CjxEmbDUyof0PzbUIka5mxgws2L eprL/Mlt08WIE+c6BPF8SU5a+iQpSBZktMTiHzZ8QpTt8ijC2hOFpDwfgxP0zr+7jSMMALq5O+6 RNJWocV3YzxiCEZk7dFP9d5Xi X-Received: by 2002:a05:6402:2794:: with SMTP id b20mr20506126ede.48.1619007987358; Wed, 21 Apr 2021 05:26:27 -0700 (PDT) X-Received: by 2002:a05:6402:2794:: with SMTP id b20mr20506111ede.48.1619007987227; Wed, 21 Apr 2021 05:26:27 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id u23sm3146200eds.8.2021.04.21.05.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 05:26:26 -0700 (PDT) Subject: Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers To: "Vaittinen, Matti" , "gregkh@linuxfoundation.org" Cc: "linux-hwmon@vger.kernel.org" , "wim@linux-watchdog.org" , "sre@kernel.org" , "linux-arm-msm@vger.kernel.org" , "jdelvare@suse.com" , "mgross@linux.intel.com" , "bjorn.andersson@linaro.org" , "lgirdwood@gmail.com" , "linux@roeck-us.net" , "platform-driver-x86@vger.kernel.org" , "wens@csie.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "myungjoo.ham@samsung.com" , "linux-watchdog@vger.kernel.org" , "agross@kernel.org" , "cw00.choi@samsung.com" , "broonie@kernel.org" References: <96935c55-c799-595e-024c-56fd352f279e@redhat.com> <2f6d096c30a6d1d22422cf9c3553d74132f75708.camel@fi.rohmeurope.com> From: Hans de Goede Message-ID: <171af93e-e5be-b35f-23d4-0ccf37062902@redhat.com> Date: Wed, 21 Apr 2021 14:26:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2f6d096c30a6d1d22422cf9c3553d74132f75708.camel@fi.rohmeurope.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/21/21 2:17 PM, Vaittinen, Matti wrote: > > On Wed, 2021-04-21 at 13:58 +0200, Hans de Goede wrote: >> Hi, >> >> On 4/21/21 9:51 AM, Matti Vaittinen wrote: >>> On Tue, 2021-03-23 at 15:19 +0100, Greg KH wrote: >>>> On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> On 3/23/21 2:56 PM, Matti Vaittinen wrote: >>>>>> Devm helper header containing small inline helpers was added. >>>>>> Hans promised to maintain it. >>>>>> >>>>>> Add Hans as maintainer and myself as designated reviewer. >>>>>> >>>>> Ultimately this is up to Greg though, so lets wait and see what >>>>> Greg has to say about this. >>>> >>>> Can we move some of the devm_* calls in include/device.h into >>>> here as >>>> well so that you all can be in charge of them instead of me? >>> >>> Seems like this was left w/o answer. I guess the question was >>> pointed >>> to Hans >> >> I believe that Greg was (mostly) joking here. At least that is how >> I interpreted Greg's reply,which is why I did not answer. > > Ah. I missed the sarcastic tone of typing. I should've noted that by > the font :] > >> Also note that Greg merged this series, but not this patch, >> so the new devm-helpers.h file will presumably be maintained by Greg. > > Hmm. Are you sure? > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=2077ca682169afb212d8a887c70057a660290df9 Ah, you're right. I was looking at the wrong branch, sorry about the confusion. Ok, so I guess I do maintain the new devm-helpers.h file, that is fine. Which makes your email from earlier today more relevant: > but what comes to my (not always so humble) opinion - most of > the devm functions in device.h are tightly related to the device > interface or devres. Thus the device.h feels like appropriate place for > most of those. I agree with you that most devm_ functions in device.h are probably left there. Moving them will also mean modifying all the drivers which use them to include the new devm-helpers.h include file which seems like needless churn. > OTOH, the kmalloc/kfree related functions, strdub and > kmemdub might be candidates for move - those are not really "device > things". I'm certainly open to moving some functions to devm-helpers.h, but also see above about needless churn. Regards, Hans