Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp532546pxy; Wed, 21 Apr 2021 08:40:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzG5U2LtkorQK5HYYBDyvE2V8f4f/Xn4RtK4xbzF0odtyYl5qpZxEyqfMFfSpbg8t92JJZY X-Received: by 2002:a05:6402:7cf:: with SMTP id u15mr32807189edy.297.1619019609307; Wed, 21 Apr 2021 08:40:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619019609; cv=none; d=google.com; s=arc-20160816; b=qElc/GQeRh4TNll4AznhWm0+n3z/I2SO0jIwTuWSby0uRCDo1mULakLeGaMoJxjMK/ VgKyYyYw0aYMeYl6+uyg4GyByu77lBPszDdDiR7jv8RKT9x/gwXvbecErarirh77xSd1 pnIC1sPkJqiQ/XysVD+SG1UAzzu6AAJkA44tsHo0dkqPryzz+6O1cS1/YN3Ld1ykherA FOqjI71HDrwPd64bhwr3OPTJgYA8VudLQlMaPinmqTWM8fu3+Ud0kFTg0mCdWbsOlnUT UZLlrUoioD1FAt9RZZexF0FY18LkeFjGMl/F7jCL2iEuPY2f2W2EAat6LlzUs+Ef8H3L Ay0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9qJSxR6eGtYRQKQaAWPyb1U9g2UBT+aT9c7lyB9vQgg=; b=VSLgnF//N4t1LSu7CglMy0J11KZOBoTkxZyRICdkCXfJrREZArtS/svrKNkUCnaHcI Wl4wm1bIp7tgMT0C8YiDi8Op0tcNs1Kg2y5Y/BTfu7X8zSQ0aeYZ3Tx8IZxFrK7YYx3M dLz1QdjixYh4J8Mqa4OF7giR2ZvFenGdcv5D0x2PktQRo5cRf80Dmylr7n9KA9c5CgVU O/l5rxviBk1XZ0no6WI43dRlS6eOFj6ceMIEIZLHkcwhPu/GoFf5YWo2jz7PdKgUwm3i hJo9ZnOLBOOPcgUHER73LQCjscGmqDZA/jcs4HfaS0hke+KOKFAVKbIh4jOPOA0LVPze NY6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WrStUCol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du3si2052616ejc.302.2021.04.21.08.39.43; Wed, 21 Apr 2021 08:40:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WrStUCol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239938AbhDUNG7 (ORCPT + 99 others); Wed, 21 Apr 2021 09:06:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240740AbhDUNF2 (ORCPT ); Wed, 21 Apr 2021 09:05:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAD4A6145C; Wed, 21 Apr 2021 13:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010294; bh=tE+D+vYphl1bcUm/plWHwtNMf6M3/jFBB6k7VRySKu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WrStUColLrjrtCTV+zcoFsp2ozcy7jAnVd6SouPFFkS1ufJKVXn3dTU0C5fOBwFVf b2hMocrL1tmXtp4AZb8khXOlCV0xDsFFtZMLw/fgaeYR8FSZLWcBUm8n7e8744LsxF lhHFkHHZRghK7bpJZFMpNgZlBeSc0NfB8FGHHEd4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Kangjie Lu , Mukesh Ojha , Stefan Schmidt Subject: [PATCH 084/190] Revert "net: ieee802154: fix missing checks for regmap_update_bits" Date: Wed, 21 Apr 2021 14:59:19 +0200 Message-Id: <20210421130105.1226686-85-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 22e8860cf8f777fbf6a83f2fb7127f682a8e9de4. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Kangjie Lu Cc: Mukesh Ojha Cc: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/mcr20a.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 8dc04e2590b1..2ce5b41983f8 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -524,8 +524,6 @@ mcr20a_start(struct ieee802154_hw *hw) dev_dbg(printdev(lp), "no slotted operation\n"); ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1, DAR_PHY_CTRL1_SLOTTED, 0x0); - if (ret < 0) - return ret; /* enable irq */ enable_irq(lp->spi->irq); @@ -533,15 +531,11 @@ mcr20a_start(struct ieee802154_hw *hw) /* Unmask SEQ interrupt */ ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL2, DAR_PHY_CTRL2_SEQMSK, 0x0); - if (ret < 0) - return ret; /* Start the RX sequence */ dev_dbg(printdev(lp), "start the RX sequence\n"); ret = regmap_update_bits(lp->regmap_dar, DAR_PHY_CTRL1, DAR_PHY_CTRL1_XCVSEQ_MASK, MCR20A_XCVSEQ_RX); - if (ret < 0) - return ret; return 0; } -- 2.31.1