Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp589599pxy; Wed, 21 Apr 2021 09:58:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8cMsW1e24RQlS0TqioaIOEVy5s0KAOybAEJP0obCb9GL+9IW0ClQzcswr62yGmy8Jmwh5 X-Received: by 2002:a05:6402:34c4:: with SMTP id w4mr40837453edc.367.1619024301567; Wed, 21 Apr 2021 09:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619024301; cv=none; d=google.com; s=arc-20160816; b=cheT+OmwXhBdWbEzYEXY4riaIAVvPsEGe4LGysqP/9w+ZpEW2qBjgGUPSjyo0UsfRS Okw1uvQaskKqmWXp8YWmyrSu6W4Fc/32217j+i1+73w+iNHosabey3kJhf727mXR552N kjDdC/3ktpiSW2MA0JGZMviLTMr0SMz7sgxdbzIIq34tRviWJ3Cv5u6sE+bjkV7p3DLe iKrJB267xdouipAE9sbXlN/RM6W/8lG400Yys9mP1TR6EoCg7IrsWE81xYhHoc3xx8Ur GMBdnddlRuuFJ62VgST2yevI5mdBTW3zAm7ew4FquDWlISMbZPAHq6fPRP6utj0Cm4M4 +Q4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=981pnAWn1udNWjBJ1WYf8lZAqietHlu3PsN0sZ9/dhI=; b=GtEpaL5o2FAwnyuJedKLH4EUtMS3hiVYvwrfzcQdcBROWxK1+5K+MzMnVErj9bRS3s SvOkR2vZshwUQ05J/p6LofDnvlUgxScImp6chAFY3gbUCKyqQ0CuNKBQiVnRD3FKKtsl S0UUQ4FNzK641NeaHisxEIyr/QE6U3dSFJEJQXAO5nuXRrIh37HTSz+4ZBD++oUZKpeI vlbDClmhVE8j8zKU9MKBmNTM8HklAJP4Mk7IbJ/7d5jWt3YcZUBeK1D45WLE6zxP6Io7 86BoUxkScCtf8kAo+4JhE43w/UOIIiday9A5WE/xZgEkAvXskUJ7eiBWGJFpKlbeoUX2 ltwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="YvGcVl8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si2599640edk.117.2021.04.21.09.57.58; Wed, 21 Apr 2021 09:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="YvGcVl8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242146AbhDUNTG (ORCPT + 99 others); Wed, 21 Apr 2021 09:19:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:49410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242010AbhDUNJn (ORCPT ); Wed, 21 Apr 2021 09:09:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 03BB06144B; Wed, 21 Apr 2021 13:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010549; bh=zYsc1oYGTs1KFsQafOVNXB3YG2pMaYsWcKLFUMtmck8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YvGcVl8/yvV4dk3E89E3485cBhAmDzX995gsk2aEYLm6L1+jK/P1pLShznBE/7rd6 W3+YMY1JFTVdOSNIzR6i96j2CLYhT35bmIwbDNv3huyhWnRIlJYz6hfytrgGuhKcI6 WqJcztbUsJTY/uO37Whuh8rr21wXUYCWaM5vykWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Aditya Pakki , "David S . Miller" Subject: [PATCH 175/190] Revert "ipv6/route: Add a missing check on proc_dointvec" Date: Wed, 21 Apr 2021 15:00:50 +0200 Message-Id: <20210421130105.1226686-176-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit f0fb9b288d0a7e9cc324ae362e2dfd2cc2217ded. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Aditya Pakki Cc: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv6/route.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 373d48073106..0e85741423d7 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -6169,16 +6169,12 @@ static int ipv6_sysctl_rtcache_flush(struct ctl_table *ctl, int write, { struct net *net; int delay; - int ret; if (!write) return -EINVAL; net = (struct net *)ctl->extra1; delay = net->ipv6.sysctl.flush_delay; - ret = proc_dointvec(ctl, write, buffer, lenp, ppos); - if (ret) - return ret; - + proc_dointvec(ctl, write, buffer, lenp, ppos); fib6_run_gc(delay <= 0 ? 0 : (unsigned long)delay, net, delay > 0); return 0; } -- 2.31.1