Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 5/7] KVM: SVM: hyper-v: Remote TLB flush for SVM
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Cc:     "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "K. Y. Srinivasan" <kys@microsoft.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org,
        Lan Tianyu <Tianyu.Lan@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, Wei Liu <wei.liu@kernel.org>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        viremana@linux.microsoft.com
References: <cover.1618492553.git.viremana@linux.microsoft.com>
 <959f6cc899a17c709a2f5a71f6b2dc8c072ae600.1618492553.git.viremana@linux.microsoft.com>
 <87sg3q7g7b.fsf@vitty.brq.redhat.com>
 <f85b1db2-3a0b-0de3-78e9-2c04721f00bc@linux.microsoft.com>
From:   Vineeth Pillai <viremana@linux.microsoft.com>
Message-ID: <3f410c6a-ed30-216e-af54-33855a2963b1@linux.microsoft.com>
Date:   Wed, 21 Apr 2021 10:03:12 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <f85b1db2-3a0b-0de3-78e9-2c04721f00bc@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 4/16/2021 1:26 PM, Vineeth Pillai wrote:
>
>>
>>   +#if IS_ENABLED(CONFIG_HYPERV)
>> +static void hv_init_vmcb(struct vmcb *vmcb)
>> +{
>> +    struct hv_enlightenments *hve = &vmcb->hv_enlightenments;
>> +
>> +    if (npt_enabled &&
>> +        ms_hyperv.nested_features & HV_X64_NESTED_ENLIGHTENED_TLB)
>> Nitpick: we can probably have a 'static inline' for
>>
>>   "npt_enabled && ms_hyperv.nested_features & 
>> HV_X64_NESTED_ENLIGHTENED_TLB"
>>
>> e.g. 'hv_svm_enlightened_tlbflush()'
> Makes sense, will do.
On a second thought, this function itself is small and just does this 
one check.
So, might not make sense to add one more function. I shall rather change 
this
function to be an inline.

Thanks,
Vineeth