Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 16:09:18 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Ashish Kalra <Ashish.Kalra@amd.com>, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, joro@8bytes.org,
        thomas.lendacky@amd.com, x86@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, srutherford@google.com,
        seanjc@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com
Subject: Re: [PATCH v13 09/12] mm: x86: Invoke hypercall when page encryption
 status is changed
Message-ID: <20210421140918.GA5004@zn.tnic>
References: <cover.1618498113.git.ashish.kalra@amd.com>
 <f2340642c5b8d597a099285194fca8d05c9843bd.1618498113.git.ashish.kalra@amd.com>
 <20210421100508.GA11234@zn.tnic>
 <f63735b4-8ec2-fdb4-0bac-8ee0921268b0@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f63735b4-8ec2-fdb4-0bac-8ee0921268b0@redhat.com>
Precedence: bulk

On Wed, Apr 21, 2021 at 02:00:42PM +0200, Paolo Bonzini wrote:
> The words are right but the order is wrong (more like "hypercall to set some
> memory's encrypted/decrypted state").  Perhaps?
> kvm_hypercall_set_page_enc_status.

Yap.

> page_encryption_changed does not sound bad to me though, it's a
> notification-like function name. Maybe notify_page_enc_status_changed?

Yap again. Those are better.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette