Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp700618pxy; Wed, 21 Apr 2021 12:46:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw36jd3OOYJI6jPGjr6xVgKf6crzREw4doPdsDdvgfQjdtJ8SGHIrDe2hsnVET7yFP6G/k5 X-Received: by 2002:a17:906:a103:: with SMTP id t3mr34994065ejy.334.1619034387627; Wed, 21 Apr 2021 12:46:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619034387; cv=none; d=google.com; s=arc-20160816; b=vCwvQ0sPn+ybM9O5jotGNGtl0Rijk3+wSi/6a/Rs3Q0EmNSg6vFpxhV9/25clrGVWW 36WCYnzsuXBBPbKF66cBn6jaAOIRpvKyYBkk0+Xkupl8ov1VhMA1MKZvVq3GqKqKFoCh 36H6UwGMBUZi5PQNnTDZO7yougOHsRebCUXZYpK/0d7Yp1C4sDCDIzCQz6h9twlEAh5C oec99dHg2CjaEM9mtu4nJhvBQNQQNqIyNsWvU+2F/9R5IswSc6EBAt3X3+U1bq8H0be1 S5u3vAA2LnsM4pAv0xZ2io00hoL4lgmyYgfiJ1Hb8CghJdrtNHYJaODDxf0eMx0VTUSS Q6oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=m6z4NmM/GYpi+uG/XNYChYnpdzM5jF8QIMHgJZA1f4M=; b=pdNmlfSF1bEXw0EOe4z4mPR1UCdGYCOQJlEIIvGG1XgKmJ/s32LEp7EOFV/V72P3DD T1jD/T3Lfp6+PggBn8imSamPxnq3F4w1XyXD704HdLoqaUg80Jiu1gF+pt9TWICLjyFj E6WNZ8Q8nPZ6wuZH7r+fTblLV9sR4oFfZ2/5RMvkYYcAOn0OEYpeUdGT7t73jiLM1bjS 3UFIn6jPrvNl62FCQEzRpc/f240m8P06YhL1yJNOtF289pVWtt9SMitQFESQLA/F2BET Rv08/IFRwZVg6/ujQmd+JC3//hUTHym/C6ZciwZIZDtagUWDqzxo+OySWPnjrycoooCe zpsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mb26si167836ejb.754.2021.04.21.12.46.04; Wed, 21 Apr 2021 12:46:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241948AbhDUOYx (ORCPT + 99 others); Wed, 21 Apr 2021 10:24:53 -0400 Received: from verein.lst.de ([213.95.11.211]:54838 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243506AbhDUOXt (ORCPT ); Wed, 21 Apr 2021 10:23:49 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E203F67373; Wed, 21 Apr 2021 16:23:14 +0200 (CEST) Date: Wed, 21 Apr 2021 16:23:14 +0200 From: Christoph Hellwig To: Dan Carpenter Cc: Jens Axboe , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] ataflop: fix off by one in ataflop_probe() Message-ID: <20210421142314.GB29072@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 01:19:45PM +0300, Dan Carpenter wrote: > Smatch complains that the "type > NUM_DISK_MINORS" should be >= > instead of >. We also need to subtract one from "type" at the start. > > Fixes: bf9c0538e485 ("ataflop: use a separate gendisk for each media format") > Reported-by: kernel test robot > Signed-off-by: Dan Carpenter Looks good, Reviewed-by: Christoph Hellwig