Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp720941pxy; Wed, 21 Apr 2021 13:18:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8X3ZSkxoq9ZRhyq0eVMInsnhrAoLJzbPDB5vO4Iyr0bdqAS+HKw1Mo6gD1OB9R1WEYmDp X-Received: by 2002:a62:5c6:0:b029:24d:e97f:1b1d with SMTP id 189-20020a6205c60000b029024de97f1b1dmr31688005pff.40.1619036305622; Wed, 21 Apr 2021 13:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619036305; cv=none; d=google.com; s=arc-20160816; b=lkC9FFPS8ZR4DLcyWnx9p82DAJOtMgdLdmGM20Hj6GPFNnwII+NYwz0tetJByxRcfc NpD1TSkMZt9IVWsUZ3ryNooO/gUWIeYGhEdm4qyxtWSedTEtRDq4SwZ03GUueCVR1Bxq I7kvUnIA55lxbcbTn5xjKsP3cz5qEnW8GzBLZNmCNXd/gv8uerSnf8HdhoYIeI8QSMRv nceUs0EhhPGz0l/5/4LV552aoNMBuXQPGQ/mj4gD7JMypnf6xkAFVwbE3TWVZHAT2Dvg 6JMUrb+15+oq26MnNic3n1utPxuWcYj9+524NoFOEFFUxD4AlqgYVc0vYLlPA49uGtay xUAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mUy7Z7Cqh/kpdpcln7GhfH2MItHWFJPtzojsUV4j4c0=; b=T3a9d8ZIW/gMhd3AXdXYZslWc0JZKAY4GTnjqj9y+4y/Hi10ju0MjFL1XOYgtxoLx9 vkSA/B11Jnxe7N9l7U7Um3pDL3Ho5juu7BfI8TCb7QKhdV1als26koG8i3/d89jKY0bP YvpjoD7rXOirLZjovU3nw6PqJs8yslHUHYEFBdxgG+Dutwj/Urq4FNMi4HL8q941PqDe VzNQONE6aAvwBzxBUjJddtoV86yCUUxWIKqwsNbZtY4riE6YkRDAqL21BOLuJ3z3QACV X2UfWmyVs4CWQpu4OQTEK6UVZSyJMA/laeCPz5ro7GSUkoMpgYzywdU5E1ka8b6pmkkb ggIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cRrCrwJ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c26si639811pfj.280.2021.04.21.13.18.05; Wed, 21 Apr 2021 13:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cRrCrwJ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239075AbhDUOsr (ORCPT + 99 others); Wed, 21 Apr 2021 10:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234550AbhDUOsq (ORCPT ); Wed, 21 Apr 2021 10:48:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E398BC06174A; Wed, 21 Apr 2021 07:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mUy7Z7Cqh/kpdpcln7GhfH2MItHWFJPtzojsUV4j4c0=; b=cRrCrwJ4naR+YdPEfib6N7bw+s MwOM7BRfTeEHbRtin6uWlv1oMsDCWSC9KnTbTwbDk0uuxphIAXycIbGGcjEG78gHZ0lsu/wLYY19Y A+Cw915I9TWZ3ceu/p2qQAd7rGoX/PQv6b/e4et/GvjYd7JcfwlzSz+cI4L7huejAzM5GbLBytNEO jfVblwf0jEEibnLLeimNariGUtm7Zrb4JY75GSbsNXhXHwfyPktk+xtzf3AfbpNirDgsBfFDHayZp ygKqI1tfLGBAeGC+NmStmiec296tFN0hutr3RBveRTMOhL6EHn6q/1gd5znbBCDRmh40kWvREB4uh 577NK8sQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lZE96-00Geqc-UG; Wed, 21 Apr 2021 14:48:05 +0000 Date: Wed, 21 Apr 2021 15:48:04 +0100 From: Christoph Hellwig To: guoren@kernel.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-arch@vger.kernel.org, Guo Ren Subject: Re: [PATCH] csky: uaccess.h: Coding convention with asm generic Message-ID: <20210421144804.GA3969416@infradead.org> References: <1618995255-91499-1-git-send-email-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1618995255-91499-1-git-send-email-guoren@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 08:54:15AM +0000, guoren@kernel.org wrote: > From: Guo Ren > > Using asm-generic/uaccess.h to prevent duplicated code: > - Add user_addr_max which mentioned in generic uaccess.h > - Remove custom definitions of KERNEL/USER_DS, get/set_fs, > uaccess_kerenl Instead of using the generic definitions removing support for set_fs entirely would be much preferred. The series in linux-next for mips, or the riscv version that landed in 5.10 might be good examples.