Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 20:33:37 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Cc:     peterz@infradead.org, acme@kernel.org, mingo@kernel.org,
        kan.liang@linux.intel.com, dave.jiang@intel.com,
        tony.luck@intel.com, dan.j.williams@intel.com,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor
 support
Message-ID: <YIA+ycNfqwytoy/Z@vkoul-mobl.Dlink>
References: <cover.1617467772.git.zanussi@kernel.org>
 <d38a8b3a5d087f1df918fa98627938ef0c898208.1617467772.git.zanussi@kernel.org>
 <YH623ULPRbdi1ker@vkoul-mobl.Dlink>
 <34f61cc9-a6d6-e5a3-5f8c-6ffae8858cce@linux.intel.com>
 <YH+/qyUVtlHwWQJ/@vkoul-mobl.Dlink>
 <410134d7-5a4d-3537-e9cc-c4c8e7068cde@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <410134d7-5a4d-3537-e9cc-c4c8e7068cde@linux.intel.com>
Precedence: bulk

On 21-04-21, 07:50, Zanussi, Tom wrote:

> > > > > +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,
> > > > > +			    char *buf);
> > > > > +
> > > > > +static cpumask_t		perfmon_dsa_cpu_mask;
> > > > > +static bool			cpuhp_set_up;
> > > > > +static enum cpuhp_state		cpuhp_slot;
> > > > > +
> > > > > +static DEVICE_ATTR_RO(cpumask);
> > > > 
> > > > Pls document these new attributes added
> > 
> > ?
> > 
> 
> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere).

They need to be, all new sysfs attributes are ABI and need to be
documented in Documentation/ABI/

Thanks
-- 
~Vinod