Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp797220pxy; Wed, 21 Apr 2021 15:33:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxK1YDb5F6CL3dwUdzn8xaIQC2ZtpuN36d8JFgc4gdaWQ2cVCYMg2GEp5KlR2sHy5CU56/Q X-Received: by 2002:a17:90a:77c8:: with SMTP id e8mr14240946pjs.69.1619044395488; Wed, 21 Apr 2021 15:33:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619044395; cv=none; d=google.com; s=arc-20160816; b=PRJy+ETjZcbmBdH+ILkhZqfQ/GK7IRbGz+ps59D5YrKU6xzxE/dbmI3qJEX1iLtjpn Ntkue6m+B4dB1qPSHlKgKejWlxdo3WiEpgfDWiYAe3zRmpDvzlfKAK05yP7bQt0iiE6B kaWID0qpsBE7rm61K4lfFI1HCOqODpNZQxwZwEyhZJwJ1hhJv/L0AS4ZQNs9wCZwQ2Lv ctBMFZjKKLlU1859IErBmZfeDh26S+GswCXXT73luuMQjj1wN2PQht2VPboVIcHVlFxh Ti+HVOVQE9EfwsMczu8HL1ai5QhuaqyJkoxHY+xVzFbeoqy/WdlNUX58f02e0Ki8qS/U SZHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=r/6P/78czMGOWvXynhkkL5aORB61zmrK7gWQX9iwSJI=; b=gVJTY1C20OXQImIoeYWneSz1wdoXn02rsXfT56rwrfdvp7Wsnz+5sg3kepQlv5SP2m bxCIPlFaknAeW0AHW8f+sjgPbWQGLETYaM5FnlOl3aa1ZvbtQ7k9Hpxpca6tglNGE+uX ewa0g8eren23fzKH0yWsctryxtjB5VLpxLIBmPLqHKiP+CnH4DdzMbB+LZ2sfEaO6b3B ejINB/7wudQUJpqstakmmWSKJ5Ndcw/1mta7flzpWSGv/xGB3PTLnhiRxH8JfPFLV1Pu uTmu+a8SWiI2j34BAHzRjXi6/5UGN6N7eDW/crk5qtxBtEf2EMHAu+kmk0OTq8MdDHXc OJKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kXb+5Hr9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si955169plr.379.2021.04.21.15.33.03; Wed, 21 Apr 2021 15:33:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kXb+5Hr9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243800AbhDUPGT (ORCPT + 99 others); Wed, 21 Apr 2021 11:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243784AbhDUPGT (ORCPT ); Wed, 21 Apr 2021 11:06:19 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E07CBC06174A; Wed, 21 Apr 2021 08:05:45 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id o16so8199034plg.5; Wed, 21 Apr 2021 08:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r/6P/78czMGOWvXynhkkL5aORB61zmrK7gWQX9iwSJI=; b=kXb+5Hr9OFnBDcgjzTb/gcVJTabEOFdI6jrvpVGEaGeyPACKTdIxIvOkEeBXChhwFu Eu4gVDMYCYp1I4Qz2jZtmnOXZSNVtU4D3gLwZMYbCri4esx0Ta00cjkH2fOpusrlnO/s 10WQ2Dd1UZaqH/ecLY6E0jpzNmwyJcQEy1BHW9fcsO0V0id6wgNCjHch2ABp8BZOYKuI M7Q+GaKPH+4CKIn+hpICl2UoKJaZR/chSV+/rNualoApd6ZRw85mw2O4JJ97Iokfh0DC LKCdEicYglLMR+UTMujKbDDG/mD4t7EOLxeOrfJ8mJWOgOF8RVgRJd1sEsBwiHzj6mmi G/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r/6P/78czMGOWvXynhkkL5aORB61zmrK7gWQX9iwSJI=; b=Xl8SKezU/oLTfe+WyZeRTmzPeaDvOr6FxvLIC24oVu2ERcMeMtRWUD5RDyILc3DOF1 Cdw5U6ldRLVZYzYKR03iC0s2QLYFU19JVwYq1YkhdvffTMfSVa54FJpijLLRK2KKWzG2 ytbkfK2+cOXiDrHZ9Dqu20nfpTimqCuQsjIAhyBYY1Y0W8HAHLPksOGfJbjrd32iaasi +0BptY/Eduvtf/76OxEG93u3sRgM99sYgMjKvA2vzqL7shnnZ/gDrxxkCws7TH8cHpG0 Zc1wnMAVAJeCTgRryxLBzvF62rc2i34Ub5B2v/rEjlUdHvQ98I8jbCmqCXZcehJZI9b6 CoGg== X-Gm-Message-State: AOAM532NxXX4oe8SD1wd4aUlx6Pyz6OvOmC612Hf77Fhq8nBfOBN8jRc eqgiERmEmnjmIIQ1PZkQZ2f+E/gLIjwugPZGXmo= X-Received: by 2002:a17:902:264:b029:eb:3d3a:a09c with SMTP id 91-20020a1709020264b02900eb3d3aa09cmr34461278plc.0.1619017545476; Wed, 21 Apr 2021 08:05:45 -0700 (PDT) MIME-Version: 1.0 References: <20210404181409.1451026-1-andy.shevchenko@gmail.com> <20210421140340.GD3@paasikivi.fi.intel.com> In-Reply-To: <20210421140340.GD3@paasikivi.fi.intel.com> From: Andy Shevchenko Date: Wed, 21 Apr 2021 18:05:29 +0300 Message-ID: Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices To: Sakari Ailus Cc: Daniel Scally , Linux Media Mailing List , Linux Kernel Mailing List , Yong Zhi , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 5:04 PM Sakari Ailus wrote: > On Sun, Apr 04, 2021 at 09:14:09PM +0300, Andy Shevchenko wrote: > > When we continue, due to device is disabled, loop we have to drop reference count. > > When we have an array full of devices we have to also drop the reference count. > > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller. > > Please limit the commit message to 75 chars, at least if there's no reason > to do otherwise. OK. > I can wrap it this time. Thanks! -- With Best Regards, Andy Shevchenko