Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1000pxy; Wed, 21 Apr 2021 16:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYgptWwT6BLOzTo4wHirZ99JWf/lSZd2BgBhNE9mD/W5wKdJZuTNX3Qt9XeLMKdBFKUZbx X-Received: by 2002:a17:902:e8d1:b029:ec:824a:404e with SMTP id v17-20020a170902e8d1b02900ec824a404emr663693plg.61.1619048096430; Wed, 21 Apr 2021 16:34:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619048096; cv=none; d=google.com; s=arc-20160816; b=KqFn0Jrslfa/0/0g2Kn7E55aOTpyLQATGvDF+d9kdpN+qKZLU1Hcq2zl0iJOA3ZnlD LtkFy2VCbaMNk3UV5GmFGPk3ZigX6bI8+/mtg2IwRAVe4JEkmkE62ef96QQvJmNqpume 9EdsK2IGUddzA95BjgPLEP17cK/I8MhfOz0esxixgP0AOIKICgL8VoJp8Uf3rtSOqzHQ sVthG5eb1INMO71CVyLMFySk5+2J+7Jbm7ZuuYKQ88S5rPEdjY4b5/hvmZq0HyHXu4wN SKl7yWRm+0SpKCDUqudMYw5EVe3CPxK4pRooVrWt09vuEaFUHInw1sw5WSGhRQRfC4xS KTZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=3c0kdOUfJX5jY3hsaf3xdiK/mvzb8p6y2kVa5dZ6M00=; b=0tJIuTKQH/tiHNDYxe1a91sC4CXEhLaV72CnJNKNIJCQLDcn9BqOYQZOWOXEfkJOUU NFqfUNEHDllkNEf5DGT/f2aeYDlUF7hbhlRr8Hcj3AcmhUuTm1piW/MOfYjulwKuEYr4 AQWZycIKqpxFaqw3w7K7vbGa7sKO7NbyFzbpDTAv+Q9ly8WHgNv9c8DcnNvDu42W0UBC RxhPxo0u+YpHgMh4TiVgQ8SqNLk0W/INdI9dghMk955gAnhKMUNVvTmuk2xn/f3q6p9b m/NPXlz8NBYsGm1X/vpMTC/PoLZablnrgy3eowOkw/c+5Eg12Zvzu/4469nb6YU0YDow n1Uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si1058600plc.189.2021.04.21.16.34.43; Wed, 21 Apr 2021 16:34:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244063AbhDUPr5 (ORCPT + 99 others); Wed, 21 Apr 2021 11:47:57 -0400 Received: from mga03.intel.com ([134.134.136.65]:7332 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240048AbhDUPr5 (ORCPT ); Wed, 21 Apr 2021 11:47:57 -0400 IronPort-SDR: 59K++GrGpblefWecCRlbGl7/HaLBLLSiEwudbnEbsgznJMTX2lZr2nuRancwVfdER88aPaOlyJ 3b8NOFeWjCDw== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195746871" X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="195746871" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 08:47:23 -0700 IronPort-SDR: +6mU2LlNAdxcSaBl9c99E4D6p7vlikuzZy16GF4EzYw2UcnMcI6qk4E8ig7vDbEfoNn49jTwHE +ybThPtXXhvQ== X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="602931060" Received: from tzanussi-mobl4.amr.corp.intel.com (HELO [10.212.81.216]) ([10.212.81.216]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 08:47:22 -0700 Subject: Re: [PATCH v2 1/1] dmaengine: idxd: Add IDXD performance monitor support To: Vinod Koul Cc: peterz@infradead.org, acme@kernel.org, mingo@kernel.org, kan.liang@linux.intel.com, dave.jiang@intel.com, tony.luck@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <34f61cc9-a6d6-e5a3-5f8c-6ffae8858cce@linux.intel.com> <410134d7-5a4d-3537-e9cc-c4c8e7068cde@linux.intel.com> From: "Zanussi, Tom" Message-ID: Date: Wed, 21 Apr 2021 10:47:21 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/2021 10:03 AM, Vinod Koul wrote: > On 21-04-21, 07:50, Zanussi, Tom wrote: > >>>>>> +static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, >>>>>> + char *buf); >>>>>> + >>>>>> +static cpumask_t perfmon_dsa_cpu_mask; >>>>>> +static bool cpuhp_set_up; >>>>>> +static enum cpuhp_state cpuhp_slot; >>>>>> + >>>>>> +static DEVICE_ATTR_RO(cpumask); >>>>> >>>>> Pls document these new attributes added >>> >>> ? >>> >> >> Yes, I'll add comments to all the attributes (also I'm assuming they don't need to be documented elsewhere). > > They need to be, all new sysfs attributes are ABI and need to be > documented in Documentation/ABI/ > OK, will do that as well, thanks for letting me know. Tom > Thanks >