Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp30624pxy; Wed, 21 Apr 2021 17:31:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNhEtomJ2SR6GQj3pSFXxLXbsOaOTb/2NVzYkfwOk6PmgRt0Mt1XHMlJeG+ZxkCg7DYWVK X-Received: by 2002:a17:90b:1d90:: with SMTP id pf16mr14623202pjb.72.1619051474140; Wed, 21 Apr 2021 17:31:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619051474; cv=none; d=google.com; s=arc-20160816; b=a3rerFWplcrPvoD3/JJ4nJ5FQ/XdTmeHGkiqPvzo8HnAmuEga/uGSQDAYUSBBKGzyn Jt38m485Ox8wn9Jim+GucaU/QJPmjTii9HNA4k+DN+7qEXGOK9ZutVVcjQr3kSRi4pkf E4eqTMKmytGW97IgVt2ADH2l7UPTh2ZFBMTFerfUazj/w753ipH7OA9xqkawjPO42HYR uIzVijjbOB22Yq2h+n1+jVGJcKKTccGtcw1DfDHKMzFWaMV1rzQ+azxnmctf8vLvOLob ob2InoSmQnGQCW0JuuLmPwYFGSgzcLHn7J90dK0qH7KJj6e77GlbJKa/FWzUOySidwsh bo4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=BLwCEQNZ42okZjG3R2PCoogsNmi2RVzghhp0dOOfrpo=; b=s+m5Xx+0zb37lKVDtgYdF+MDwiBu6TiVpdQjmtlTdFkOu+1SC12rif64ZzhTjTGrUU WDeVQs0+mVmOKvdpg2hwAOeomA3OW2VA9fR0Qn6J4KHdfm0FKbWstfhyg7Jt2k6qjYo+ wrmBypy0QrDVWCWP/B75w1NsH1yn4yQp4phaWzQgfMhtlKFQSJ44AVwrUSvEQ9QmxiCv x6RWcVuvJPzQW3BgDywnIJQViEWGyPsycUn1N9PgNsjusvxoxoLJMzKFBao+nh6pBuBa EOPSyqOcmlsuR++yiU8ja3yA4N27CxfK9itdPJjr1RPGJA6M0C5UVJEl3GOI01s5Wx2U UePA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h123si1290251pfb.251.2021.04.21.17.30.34; Wed, 21 Apr 2021 17:31:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237672AbhDUQQz (ORCPT + 99 others); Wed, 21 Apr 2021 12:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236051AbhDUQQx (ORCPT ); Wed, 21 Apr 2021 12:16:53 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E8CA0C06174A; Wed, 21 Apr 2021 09:16:19 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 8A87E92009C; Wed, 21 Apr 2021 18:16:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 7BE6A92009B; Wed, 21 Apr 2021 18:16:18 +0200 (CEST) Date: Wed, 21 Apr 2021 18:16:18 +0200 (CEST) From: "Maciej W. Rozycki" To: "H. Nikolaus Schaller" , Thomas Bogendoerfer cc: Arnd Bergmann , Huacai Chen , Huacai Chen , Jiaxun Yang , linux-arch@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero In-Reply-To: <284CBC37-0F4F-4077-A172-7E47C90B8B43@goldelico.com> Message-ID: References: <284CBC37-0F4F-4077-A172-7E47C90B8B43@goldelico.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021, H. Nikolaus Schaller wrote: > > We already check the high part of the divident against zero to avoid the > > nit-picking: s/divident/dividend/ Umm, I find this embarassing (and I hesitated reaching for a dictionary to double-check the spelling!). Indeed why would this be different from subtrahend or minuend? Thomas, as this mistake has spread across three out of these patches, both in change descriptions and actual code, would you mind dropping the series from mips-next altogether and I'll respin the series with all these issues corrected? Maciej