Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp36326pxy; Wed, 21 Apr 2021 17:43:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr7idJARTJbnY3H3i2n/uxZt3NNlXOzOzGIRBg3PbWGs/Osiq8dgZ1CRssLIcxNjG0DXlm X-Received: by 2002:a17:902:8ec1:b029:e9:998d:91f3 with SMTP id x1-20020a1709028ec1b02900e9998d91f3mr713366plo.59.1619052186365; Wed, 21 Apr 2021 17:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619052186; cv=none; d=google.com; s=arc-20160816; b=GcsYW0JlSR7dWzUohIblZU5uSjjLrHq6ZaeFupg+Fx50yRbb7HQmCjclV5LFIrn6Xt XQcdX48LGBCMEIR7dtzU4dNVQBgSv0bQF8ZDWr6JANGL1iVlOcQx467Jlmdp8RIMRVW3 wxYnGRlEHW/BKccika0aCrvQkzu0vXg+7z/pkm1Kg8MwggnPB4vNcrtP+sSqZTomgxxf sXeVupvqWDvIfipeccxx4UbvkdzTOY96kL1OXroR3rkepeyC6VzRt3bakEyKVPvDUpe4 Y/CsgQYI3s5Tb8t/UV/DpsLPpuSUqCoSz6Q16f72ZMQLTJJpXItGFTgauwoRxzGXfkde mHtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=dbbH5mU0eZQOvfNmncVtsU5aW1qxNpTR7xNLktkxO/8=; b=l0qASZwmonEk/9PozcpEgcLkBaQ9AGOLvvTC5tb+NetwQjEOYhBFSbSMyj6Vo8XVu/ T3xm47FuA+Ik6i/PDHULWgZtUZP8aArBMvmlqVXZja+q6SezdzZwnxmQKsXQNIC+4M6H EaciRA3TuFoKyyv0mNs7sjHdRioNQ7fIKo6Re9chfaitFSJbRy8gSAP26fp1LQGphYFe ep5M5Fln4XsfbEzsyNUrmnflcAnBAMM7AFaG1TPZ8tcA9vl2KHbBDlPQbMwDkpvPHKGQ X/xij/wFFi4GZ6CHx4WQszssSSD+esT6wK6xP5Q3b7S4d17vhZTFhD4Y7ElxHjoLcsXn kpAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r2pyaVk2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r186si1220829pgr.324.2021.04.21.17.42.53; Wed, 21 Apr 2021 17:43:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=r2pyaVk2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241662AbhDUQdV (ORCPT + 99 others); Wed, 21 Apr 2021 12:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241136AbhDUQdQ (ORCPT ); Wed, 21 Apr 2021 12:33:16 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72F4C06174A; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id m12so9672419pgr.9; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dbbH5mU0eZQOvfNmncVtsU5aW1qxNpTR7xNLktkxO/8=; b=r2pyaVk2t6foNEjWeJgrpPuyNXGzX/dF+DIu22dYUss19nfc4lBaUxn8OQ7azwSplI nX0gqVnTVlg1Us4NtxIYike5JKI8ygpel1bfLgzbjgKWHP86RfWJwIFVWCEIGpfHMMen YSJ8fR20KjjLk761nB5Dh9Z5TpXopTYm1z9A+YSNH7rWN0FwIBk/c5x8UmyZpIEoRODx 2m6aBQSr+UxyCfr0cPeKKQgmonBo9iNxhzYfECMVWEI8ZqTf58H4wuJ/BiU9/ZwPvOSO 6aMPDMlnpWANyfXqvjOwsfzd2ak8rZOIK9LfFnmI4MC/LWPZv2B7nKoEMZvFeCsPEHd7 qW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dbbH5mU0eZQOvfNmncVtsU5aW1qxNpTR7xNLktkxO/8=; b=Rv5CrSZ5cenWSj0f63jb3CMTDooPHVjADd3/XJfbC33AIeT54XXz75WCNkbMR5njti USBeIrufxe7B4Xo6LMUj6vzqkVMjaAtdXAdq2h3tGvGn6tgmTnKBdfe9RxMvJx+pC8zJ eEj0ViQUFU2+6/i1D5c8IuFSwVjmsBeHS+BR7U65u3KVkTARzEwTQyHWH1VOFTbMtWVU hQDKIjlGWSgkxujWex2Xa2k36Mlrfdkz/es4fymas9Yh3Sb5vYrn9/ttdERCAWifJjjQ ddy77Gn2pPMglkEBE4QD0nCLZ62EO9jtsHEqMjik5l5ZPR6qCw6Hcl33urHIeFr3XQds 5quQ== X-Gm-Message-State: AOAM5319luzG+hHKZEfO7goTMHIm/GH/w7e0ymPsNHRCrnBMBKEnHlC1 431mvgUmFVt2saNtfD+4Oqfr56Y/sk4= X-Received: by 2002:a17:90a:c209:: with SMTP id e9mr12234306pjt.104.1619022762408; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id s22sm2630721pjs.42.2021.04.21.09.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 09:32:41 -0700 (PDT) Subject: Re: [PATCH net-next v1] net: dsa: fix bridge support for drivers without port_bridge_flags callback To: Oleksij Rempel , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski Cc: kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King References: <20210421130540.12522-1-o.rempel@pengutronix.de> From: Florian Fainelli Message-ID: Date: Wed, 21 Apr 2021 09:32:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210421130540.12522-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/2021 6:05 AM, Oleksij Rempel wrote: > Starting with patch: > a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags") > > drivers without "port_bridge_flags" callback will fail to join the bridge. > Looking at the code, -EOPNOTSUPP seems to be the proper return value, > which makes at least microchip and atheros switches work again. > > Fixes: a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags") > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian